1299207 - Remove unused import in test_click.py

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

This import [1] isn't used anywhere in the test. Let's remove it.

[1] https://dxr.mozilla.org/mozilla-central/rev/26e22af660e543ebb69930f082188b69ec756185/testing/marionette/harness/marionette/tests/unit/test_click.py#10

You can run the test with |./mach marionette-test testing/marionette/harness/marionette/tests/unit/test_click.py|

To get started, see https://wiki.mozilla.org/index.php?title=User:Mjzffr/New_Contributors

Comment 1

[Rajib Mitra]

Hi, 
I would like to do this , if this is ok with you . Actually looking for my first bug.

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Sure. I will assign the bug to you once you submit code up for review through MozReview. In the mean time, if you have any questions, ask on #automation.

Comment 3

[Bhuvnesh Maheshwari]

Hello ,
I am newbie.This is my first bug.
When I submit code for review it gives something like this

redirecting push to https://reviewboard-hg.mozilla.org/gecko
(ignoring public changeset cfdb7af3af2e in review request)
abort: no non-public changesets left to review
(add or change the -r argument to include draft changesets)

Please help me with this.

Comment 4

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Hi! Please join #automation on irc.mozilla.org (See https://wiki.mozilla.org/index.php?title=User:Mjzffr/New_Contributors for info about IRC) and ask us troubleshooting questions there.

Comment 5

[Bhuvnesh Maheshwari]

Attachment: Bug 1299207 - Removed unnecessary header files.

Review commit: https://reviewboard.mozilla.org/r/78712/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/78712/

Comment 6

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8791242 [details]
Bug 1299207 - Removed unnecessary header files.

https://reviewboard.mozilla.org/r/78712/#review77304

Thanks for the patch!

A couple of changes are needed (you can do an `hg histedit` then `hg push review` again).

Please change your commit message to the following: `Bug 1299207 - Remove unused imports in test_click.py; r?maja_zf`

::: testing/marionette/harness/marionette/tests/unit/test_click.py:6
(Diff revision 1)
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> -from unittest import skip
>  
> +from unittest import skip

Please move `from unittest import skip` back to line 5. (We group standard library imports separately.)

Comment 7

[Bhuvnesh Maheshwari]

Attachment: Bug 1299207 - Remove unused imports in test_click.py;

Review commit: https://reviewboard.mozilla.org/r/79022/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79022/

Comment 8

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8791660 [details]
Bug 1299207 - Remove unused imports in test_click.py;

https://reviewboard.mozilla.org/r/79022/#review77600

The second changeset is good. I'm giving an r- because you need to squash the two changesets together into one, using the second commit message. Use |hg histedit| to do this, then |hg push review|

Your final commit message should include the same MozReview-Commit-ID, like this:
```
Bug 1299207 - Remove unused imports in test_click.py; r?maja_zf

MozReview-Commit-ID: 9dDvAcsbZnS
```

Comment 9

[Bhuvnesh Maheshwari]

hg histedit opens this file https://pastebin.mozilla.org/8910506
What do I do next?

Comment 10

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Please read the instructions that are in the file opened by |hg histedit|, and read how to use hg histedit here: https://www.mercurial-scm.org/wiki/HisteditExtension -- I found this by searching "hg histedit" on Google.

In this case, you need to mark that the second commit should be combined with the first, then mark that you want to change the message for the first commit, then save and close the file. hg histedit will read the file and continue with the changes you asked for.

If you run into problems/errors that you can't fix or if you have more specific questions, let us know.

Comment 11

[Bhuvnesh Maheshwari]

Comment on attachment 8791660 [details]
Bug 1299207 - Remove unused imports in test_click.py;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/79022/diff/1-2/

Comment 12

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8791660 [details]
Bug 1299207 - Remove unused imports in test_click.py;

https://reviewboard.mozilla.org/r/79022/#review77906

Thanks!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a60d2f3b702
Remove unused imports in test_click.py; r=maja_zf

Comment 14

[Bhuvnesh Maheshwari]

maja_zf: Can you please vouch me  https://mozillians.org/en-US/u/bhuvi96/

Comment 15

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

I can vouch you once you make a few more substantial contributions. :)

Comment 16

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0a60d2f3b702