Add click support to AS topsites

RESOLVED FIXED in Firefox 51

Status

()

Firefox for Android
Awesomescreen
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: ahunt, Assigned: ahunt)

Tracking

Trunk
Firefox 51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

(Whiteboard: [MobileAS])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

a year ago
Clicking on TopSites does nothing right now.

We need to:
1 - add OnUrlOpenListener plumbing to ActivityStream
2 - hook the topsites view up to open pages when selected
(Assignee)

Updated

a year ago
Assignee: nobody → ahunt
Whiteboard: [MobileAS]
(Assignee)

Updated

a year ago
Depends on: 1293790
(Assignee)

Updated

a year ago
Priority: -- → P1
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Status: NEW → ASSIGNED

Comment 3

a year ago
mozreview-review
Comment on attachment 8786907 [details]
Bug 1299224 - Pre: remove unnecessary LoaderManager reference from StreamAdapter

https://reviewboard.mozilla.org/r/75780/#review73922

::: mobile/android/base/java/org/mozilla/gecko/home/activitystream/ActivityStream.java:22
(Diff revision 1)
> -import org.mozilla.gecko.home.HomeFragment;
> -import org.mozilla.gecko.home.HomeScreen;
>  import org.mozilla.gecko.home.SimpleCursorLoader;
>  import org.mozilla.gecko.home.activitystream.topsites.TopSitesPagerAdapter;
>  
>  public class ActivityStream extends FrameLayout {

Unrelated: Didn't we want to rename this so that we do not have two classes named "ActivityStream"?

::: mobile/android/base/java/org/mozilla/gecko/home/activitystream/ActivityStream.java:40
(Diff revision 1)
>          RecyclerView rv = (RecyclerView) findViewById(R.id.activity_stream_main_recyclerview);
>  
> -        // TODO: we need to retrieve BrowserApp and pass it in as onUrlOpenListener. That will
> -        // be simpler once we're a HomeFragment, but isn't so simple while we're still a View.
> -        adapter = new StreamRecyclerAdapter(lm, null);
>          rv.setAdapter(adapter);
>          rv.setLayoutManager(new LinearLayoutManager(getContext()));
>          rv.setHasFixedSize(true);

Can't you do those assignments in the constructor too? inflate() should return the inflated view on which you can call findViewById().
Attachment #8786907 - Flags: review?(s.kaspari) → review+

Comment 4

a year ago
mozreview-review
Comment on attachment 8786908 [details]
Bug 1299224 - pass OnUrlOpenListener into StreamRecyclerAdapter

https://reviewboard.mozilla.org/r/75782/#review73930
Attachment #8786908 - Flags: review?(s.kaspari) → review+
(Assignee)

Comment 5

a year ago
https://hg.mozilla.org/integration/fx-team/rev/35b31a0d906aa6d618feb11592aaa5aec924db49
Bug 1299224 - Pre: remove unnecessary LoaderManager reference from StreamAdapter r=sebastian

https://hg.mozilla.org/integration/fx-team/rev/3d376f300eac2ed52d331a47b4608c7719013bae
Bug 1299224 - pass OnUrlOpenListener into StreamRecyclerAdapter r=sebastian

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/35b31a0d906a
https://hg.mozilla.org/mozilla-central/rev/3d376f300eac
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Iteration: --- → 1.3
You need to log in before you can comment on or make changes to this bug.