1299247 - [e10s] Increase e10s activation on the release channel to 100% of eligible users

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

+++ This bug was initially created as a clone of Bug #1292721 +++

We should update the e10srollout system add-on to 48.* users to configure e10s to be activated at the 100% threshold (that is, every eligible user).

In addition, we should land this increase on mozilla-beta, so that the 49 RC is built with the 100% setting built-in.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1299247 - Increase e10s activation on the release channel to 100% of eligible users.

Review commit: https://reviewboard.mozilla.org/r/75372/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/75372/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8786436 [details]
Bug 1299247 - Increase e10s activation on the release channel to 100% of eligible users.

https://reviewboard.mozilla.org/r/75372/#review73264

\o/

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8786436 [details]
Bug 1299247 - Increase e10s activation on the release channel to 100% of eligible users.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/75372/diff/1-2/

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8786436 [details]
Bug 1299247 - Increase e10s activation on the release channel to 100% of eligible users.

Approval Request Comment
[Feature/regressing bug #]: increase e10s activation rate
[User impact if declined]: e10s remains at 10%
[Describe test coverage new/current, TreeHerder]: addon is running on beta and release
[Risks and why]: small risk for the change itself, it just changes a configuration line in the e10srollout addon. Of course, this means we're going to 100% of eligible users for e10s, but that has already been discussed.
[String/UUID change made/needed]: -

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Attachment: Unsgined xpi for signing

Comment 6

[:Felipe Gomes (needinfo for replies!)]

Attachment: update.xml

Mark, I updated the shasum and size for the e10srollout addon and kept the pocket/hello ones from the current response that I got from the update server.

Can you verify that this update.xml looks correct so I can ask QA to use it to test? Or better yet configure Balrog for a test channel with this update?

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8786436 [details]
Bug 1299247 - Increase e10s activation on the release channel to 100% of eligible users.

Sgtm, Aurora50+

Comment 8

[:Felipe Gomes (needinfo for replies!)]

Hi Andrei, could you verify this update?

1. Using a clean profile from Firefox release 48.0 and 48.0.2

2. Go to about:support and verify:

 - Multiprocess Windows: 0/1 (Disabled)
    This has a 90-99% random chance of being correct (disabled). If not disabled, start another clean profile

 - Installed extensions:
   - Firefox Hello Beta,   version 1.4.3     (or 1.4.4 with 48.0.2)
   - Pocket,               version 1.0.4
   - Multi-process staged rollout, 1.0       (or 1.1 with 48.0.2)

3. Go to about:config and change the following:
  - devtools.chrome.enabled, set to true
  - extensions.systemAddon.update.url set to "http://people.mozilla.org/~fgomes/e10s-update/update-1.2.xml" (no quotes)

4. Force an add-on update check, by running the following in Tools > Web Developer > Browser Console:

    Components.utils.import("resource://gre/modules/AddonManager.jsm");
    AddonManagerPrivate.backgroundUpdateCheck();

5. Wait a minute in order for the update to download, then restart

6. After a restart, check in about:support

  - Multiprocess Windows: 1/1 (Enabled)

  - Installed extensions:
   - Firefox Hello Beta,   version 1.4.4
   - Pocket,               version 1.0.4
   - Multi-process staged rollout, 1.2

7. And then do some basic sanity check that Hello and Pocket functionality works

Comment 9

[:Felipe Gomes (needinfo for replies!)]

Attachment: update.xml

(updated version attribute from the previous xml)

Comment 10

[Andrei Vaida [:avaida]]

Felipe, we're currently blocked by an error that immediately follows Step 4 
(force add-on update check):

1472631256136 addons.xpi ERROR Failed to download system add-on
[e-mail]: Error: Hash was `8d8bce508309d0c52c1551e0a1837d566a59b
28ba0bd94626d77252616f2002808239448b619d49e12212a2c740a5221611b0073168a30fd8a21
c866d028f899` but expected `015101a721e885a95170d978adf14d5e7b424b29972edd07ea9
da882b08d0500e25f84af6d1d44636c2574bca1bec525423e957dff6233b46d2fd6e6d5a0170a`.
(resource://gre/modules/addons/ProductAddonChecker.jsm:299:13) JS Stack trace:
verifyFile<@ProductAddonChecker.jsm:299:13

	App_append() Log.jsm:753
	Logger.prototype.log() Log.jsm:389
	Logger.prototype.error() Log.jsm:397
	this.XPIProvider.updateSystemAddons</downloadAddon<() XPIProvider.jsm:3060
	throw() self-hosted
	TaskImpl_run() Task.jsm:320
	bound TaskImpl_run() self-hosted
	Handler.prototype.process() Promise-backend.js:940
	this.PromiseWalker.walkerLoop() Promise-backend.js:816
	bound () self-hosted
	bound bound () self-hosted
	this.PromiseWalker.scheduleWalkerLoop/<() Promise-backend.js:750

Comment 11

[Mark Banner (:standard8)]

It looks like Felipe accidentally used the hash for the unsigned xpi rather than the signed one.

I've now done the work for this to be on Balrog. You can point your channel-prefs.js to "release-sysaddon" channel.

The update should have Loop 1.4.4 (same as currently being served to FF 48.0, and built-into FF 48.0.1), and Pocket 1.0.4 (same as shipped with 48.*), and, of course this 1.2 version for the multiprocess.

Comment 12

[Mark Banner (:standard8)]

Felipe: If there's going to be future updates to the add-on, can we add "release-sysaddon" as a supported channel that matches the "release" channel?

This will make it simpler for QA to test on via the update system.

Comment 13

[Andrei Vaida [:avaida]]

After a few bumps, we've managed to confirm that the Multi-process staged
rollout system add-on is being successfully updated to version 1.2 on:

  - 48.0-build2 (20160726073904),
  - 48.0.2-build1 (20160823121617),

using Windows 7 x86, Windows 10 x64, Mac OS X 10.9.5 and Ubuntu 16.04 x64, with
slightly different instructions based on Mark's suggestions, here's an
overview:

  1. set the update channel to release-sys add-on
  2. started Firefox with a clean profile
  3. confirmed that the about:support#extensions is showing the expected values
     for the installed extensions
  4. forced an add-on update check
  5. once the update was downloaded, we've closed the browser, changed back the
     update channel to release and started the browser back
  6. confirmed that the about:support#extensions is showing the expected values
     for the installed extensions, especially v1.2 for the Multi- process
     staged rollout
  7. confirmed that the core functionality associated to Hello and Pocket is
     working in the expected parameters

Please note that these tests were only performed on a single locale: en-US.

Detailed test results are available here:

  https://testrail.stage.mozaws.net/index.php?/plans/view/448

Let me know if there's anything else we can help with here.

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8786436 [details]
Bug 1299247 - Increase e10s activation on the release channel to 100% of eligible users.

Taking it on all branches.

Comment 15

[:Felipe Gomes (needinfo for replies!)]

(In reply to Mark Banner (:standard8) from comment #12)
> Felipe: If there's going to be future updates to the add-on, can we add
> "release-sysaddon" as a supported channel that matches the "release" channel?
> 
> This will make it simpler for QA to test on via the update system.

Thanks for fixing the hash and configuring the test server. I indeed had used the hash from the unsigned file in my test update.xml.

I can include "release-sysaddon" in the future, but there's a simpler solution that doesn't require it. Instead of changing channel-prefs.js, we can just suggest to modify the extensions.systemAddon.update.url pref by replacing the "%CHANNEL%" part with "release-sysaddon".

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c30772c727e
Increase e10s activation on the release channel to 100% of eligible users. r=mconley

Comment 17

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1c30772c727e
https://hg.mozilla.org/releases/mozilla-aurora/rev/fa475195cce7
https://hg.mozilla.org/releases/mozilla-beta/rev/d13386c15659
https://hg.mozilla.org/releases/mozilla-release/rev/e8296ee31e8d

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1c30772c727e

Comment 19

[:Felipe Gomes (needinfo for replies!)]

Just for keeping record, this was pushed live on Sep 1 20:54 UTC