1299393 - Return values are not used at all for some functions of MDSM

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

They can just return void.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1299393. Part 1 - make some functions return void and fix the comments.

Review commit: https://reviewboard.mozilla.org/r/76562/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76562/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1299393. Part 2 - remove unused functions.

Review commit: https://reviewboard.mozilla.org/r/76564/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76564/

Comment 3

[Tzuhao Kuo [:kaku]]

Comment on attachment 8788022 [details]
Bug 1299393. Part 1 - make some functions return void and fix the comments.

https://reviewboard.mozilla.org/r/76562/#review74696

Comment 4

[Tzuhao Kuo [:kaku]]

Comment on attachment 8788023 [details]
Bug 1299393. Part 2 - remove unused functions.

https://reviewboard.mozilla.org/r/76564/#review74698

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e79e89e8da7
Part 1 - make some functions return void and fix the comments. r=kaku
https://hg.mozilla.org/integration/autoland/rev/54d3418f365e
Part 2 - remove unused functions. r=kaku

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/7e79e89e8da7
https://hg.mozilla.org/mozilla-central/rev/54d3418f365e