Stylo hits an assertion when a ContentInserted arrives with a comment as the new child.

RESOLVED FIXED in Firefox 51

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: emilio, Assigned: emilio)

Tracking

(Blocks: 1 bug)

unspecified
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Regression from bug 1292279.

I planned to land this patch along with bug 1297899, but that's taking a while more it seems, so I'd rather stop others from hitting this.
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Blocks: 1243581
(Assignee)

Comment 2

2 years ago
Well, I'd rather reword the commit message to say something like |Don't style non-significant nodes on ContentInserted/Appended|, but you get the idea.

Comment 3

2 years ago
mozreview-review
Comment on attachment 8786638 [details]
Bug 1299396: Don't style content that is not an element or a text node in ServoStyleSet::StyleNewSubtree.

https://reviewboard.mozilla.org/r/75572/#review73732

Per IRC discussion, let's move this to a node type check in StyleNewSubtree.
Attachment #8786638 - Flags: review?(bobbyholley) → review-
Comment hidden (mozreview-request)

Comment 5

2 years ago
mozreview-review
Comment on attachment 8786638 [details]
Bug 1299396: Don't style content that is not an element or a text node in ServoStyleSet::StyleNewSubtree.

https://reviewboard.mozilla.org/r/75572/#review73752

Thanks.
Attachment #8786638 - Flags: review?(bobbyholley) → review+

Comment 6

2 years ago
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/dfc059b71968
Don't style content that is not an element or a text node in ServoStyleSet::StyleNewSubtree. r=bholley

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/dfc059b71968
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.