1299396 - Stylo hits an assertion when a ContentInserted arrives with a comment as the new child.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

Regression from bug 1292279.

I planned to land this patch along with bug 1297899, but that's taking a while more it seems, so I'd rather stop others from hitting this.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1299396: Don't style content that is not an element or a text node in ServoStyleSet::StyleNewSubtree.

This was breaking some assertions in Servo, since we were calling
StyleNewSubtree with a node that is, e.g., a comment.

Review commit: https://reviewboard.mozilla.org/r/75572/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/75572/

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Well, I'd rather reword the commit message to say something like |Don't style non-significant nodes on ContentInserted/Appended|, but you get the idea.

Comment 3

[Bobby Holley (:bholley)]

Comment on attachment 8786638 [details]
Bug 1299396: Don't style content that is not an element or a text node in ServoStyleSet::StyleNewSubtree.

https://reviewboard.mozilla.org/r/75572/#review73732

Per IRC discussion, let's move this to a node type check in StyleNewSubtree.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8786638 [details]
Bug 1299396: Don't style content that is not an element or a text node in ServoStyleSet::StyleNewSubtree.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/75572/diff/1-2/

Comment 5

[Bobby Holley (:bholley)]

Comment on attachment 8786638 [details]
Bug 1299396: Don't style content that is not an element or a text node in ServoStyleSet::StyleNewSubtree.

https://reviewboard.mozilla.org/r/75572/#review73752

Thanks.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfc059b71968
Don't style content that is not an element or a text node in ServoStyleSet::StyleNewSubtree. r=bholley

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dfc059b71968