Closed Bug 1299396 Opened 7 years ago Closed 7 years ago

Stylo hits an assertion when a ContentInserted arrives with a comment as the new child.

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla51
Tracking Flags:
Tracking Status
firefox51 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

Bug 1299396: Don't style content that is not an element or a text node in ServoStyleSet::StyleNewSubtree.
58 bytes, text/x-review-board-request
bholley
: review+
Details 
Regression from bug 1292279.

I planned to land this patch along with bug 1297899, but that's taking a while more it seems, so I'd rather stop others from hitting this.
Blocks: stylo
Well, I'd rather reword the commit message to say something like |Don't style non-significant nodes on ContentInserted/Appended|, but you get the idea.
Comment on attachment 8786638 [details]
Bug 1299396: Don't style content that is not an element or a text node in ServoStyleSet::StyleNewSubtree.

https://reviewboard.mozilla.org/r/75572/#review73732

Per IRC discussion, let's move this to a node type check in StyleNewSubtree.
Attachment #8786638 - Flags: review?(bobbyholley) → review-
Comment on attachment 8786638 [details]
Bug 1299396: Don't style content that is not an element or a text node in ServoStyleSet::StyleNewSubtree.

https://reviewboard.mozilla.org/r/75572/#review73752

Thanks.
Attachment #8786638 - Flags: review?(bobbyholley) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/dfc059b71968
Don't style content that is not an element or a text node in ServoStyleSet::StyleNewSubtree. r=bholley
https://hg.mozilla.org/mozilla-central/rev/dfc059b71968
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.