1299408 - can't get TabID from loadContext

Status: RESOLVED FIXED

(Developer Documentation Graveyard :: Add-ons, defect)

Description

[Criss Anger]

Attachment: index.js

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36

Steps to reproduce:

Here is My code:

Cu.import('resource://gre/modules/Services.jsm');

var httpObs = {
    observe: function (aSubject, aTopic, aData) {
        if (aTopic == 'http-on-modify-request') {
            /*start - do not edit here*/
            var oHttp = aSubject.QueryInterface(Ci.nsIHttpChannel); //i used nsIHttpChannel but i guess you can use nsIChannel, im not sure why though
            var interfaceRequestor = oHttp.notificationCallbacks.QueryInterface(Ci.nsIInterfaceRequestor);
            //var DOMWindow = interfaceRequestor.getInterface(Ci.nsIDOMWindow); //not to be done anymore because: https://developer.mozilla.org/en-US/docs/Updating_extensions_for_Firefox_3.5#Getting_a_load_context_from_a_request //instead do the loadContext stuff below
            var loadContext;
            try { 
                loadContext = aSubject.QueryInterface(Ci.nsIChannel) // aSubject is equivalent to aSubject from observe
                                      .notificationCallbacks 
                                      .getInterface(Ci.nsILoadContext);
            } catch (ex) { 
                try { 
                    loadContext = aSubject.loadGroup.notificationCallbacks 
                                          .getInterface(Ci.nsILoadContext); 
                } catch (ex) {
                    loadContext = null;
                }
            }
            /*end do not edit here*/
            /*start - do all your edits below here*/
            var url = oHttp.URI.spec; //can get url without needing loadContext
            if(loadContext){
                var window = loadContext.associatedWindow;
                 var utab = utabs.getTabForContentWindow(window);
                 console.log(utabs.getTabId(utab));
            }

        }
    }
};
Services.obs.addObserver(httpObs, 'http-on-modify-request', false);


Actual results:

console.log: test: -5-2
console.log: test: -5-2
console.log: test: -5-2
console.log: test: -5-2
console.log: test: -5-2
console.log: test: -5-2
console.log: test: -5-2
console.log: test: -5-2
console.log: test: -5-2
console.log: test: -5-2
console.log: test: -5-2
console.log: test: -5-2
console.log: test: -5-2


Expected results:

console.log: test: -5-1
console.log: ....
console.log: test: -5-1
console.log: test: -5-2
console.log: ....
console.log: test: -5-2
console.log: test: -5-3
console.log: ....
console.log: test: -5-3

Comment 1

[Criss Anger]

I think there should be a way to help us get tabID without nsIDOMWindow. Can we create a different channel (eg nsITab) used to connect via methods QueryInterface.

Comment 2

[:shell escalante]

looks like this needs to be updated on mdn

Comment 3

[Kris Maglione [:kmag]]

That page should probably just be archived.

Comment 4

[Criss Anger]

Has not been corrected in version 52

Comment 5

[Kris Maglione [:kmag]]

Will, can you please archive this page? https://developer.mozilla.org/en-US/Add-ons/Code_snippets/Tabbed_browser

Comment 6

[Will Bamberg [:wbamberg]]

-> https://developer.mozilla.org/en-US/docs/Archive/Add-ons/Tabbed_browser

Comment 7

[Criss Anger]

(In reply to Will Bamberg [:wbamberg] from comment #6)
> -> https://developer.mozilla.org/en-US/docs/Archive/Add-ons/Tabbed_browser

No way to get tabID from HTTPChannel?