1299410 - Shrink TextureClientRecycleAllocator more aggressively

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Sotaro Ikeda [:sotaro]]

When TextureClientRecycleAllocator::ShrinkToMinimumSize() is called, it clears only mPooledClients. mInUseClients also needs to be cleared.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Shrink TextureClientRecycleAllocator more aggressively

Comment 2

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b58064f7f87&selectedJob=26714374

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/42031a1a09e8
Shrink TextureClientRecycleAllocator more aggressively r=nical

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/42031a1a09e8

Comment 5

[Sotaro Ikeda [:sotaro]]

From Bug 1299415 Comment 4, I re-checked attachment 8786648 [details] [diff] [review]. It has a problem. It releases TextureClient without clearing the callback. But we do not have a safe way to clear a callback until the callback is called.

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: patch - backout attachment 8786648

Comment 7

[Sotaro Ikeda [:sotaro]]

Attachment: patch ver2 - Shrink TextureClientRecycleAllocator

Comment 8

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=150475ccbd6f

Comment 9

[Nicolas Silva [:nical]]

Comment on attachment 8787486 [details] [diff] [review]
patch ver2 - Shrink TextureClientRecycleAllocator

Review of attachment 8787486 [details] [diff] [review]:
-----------------------------------------------------------------

Too bad, I much preferred the simplicity of the previous version. We should really simplify the recycling system (there are much simpler ways than the callback mechanism).

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d082b9cabd17
Shrink TextureClientRecycleAllocator more aggressively r=nical

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d082b9cabd17