1299465 - Delete all other crash data classes

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Peter Bengtsson [:peterbe]]

In https://bugzilla.mozilla.org/show_bug.cgi?id=1262252 we're adding yet another class for fetching crash data (e.g. minidumps, raw json, processed json). This time it's only for S3 (aka. boto). 

We currently have the following classes ALL to do with CrashData:

▶ ff crash_data | grep -v unittest
socorro/external/boto/crash_data.py (*)
socorro/external/crash_data_base.py
socorro/external/fs/crash_data.py
socorro/external/happybase/crash_data.py
socorro/external/hb/crash_data.py
socorro/external/postgresql/crash_data.py

(*) This is the new one that https://bugzilla.mozilla.org/show_bug.cgi?id=1262252 adds.

All are legacy and relics of a past when we tried to make socorro ultra flexible for non-Mozilla deployments. Something that's not a priority any more. 

Let's clean it all up, with its tests but be careful that processing and collector still works as expected.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

What does "clean it all up" entail here? Are we talking about refactoring the code or removing it or something else?

Comment 2

[Peter Bengtsson [:peterbe]]

*Remove* is what I had in mind. 

I think the "fs" crash storage was only used for integration testing and pellet stoves. The happybase and hb (short for HBase) are definitely not in use. And the postgresql is less obvious(*). 

(*) As of Jan 2018, I believe the postgres crash *storage* is still in use, but is the crash *data* class in use? I doubt it but can't confidently assert that.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

I just hit issues related to this. I'm going to remove them all except for boto and maybe fs.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4331: fix bug 1299465 - nix CrashData classes we're not using

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4332: fix bug 1299465, 1435551 - remove CrashData classes and stop saving to processed_crashes_* tables

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/f3d792b6d9d2e3d77349811d609d932b335d9e67
fix bug 1299465 - nix CrashData classes we're not using

https://github.com/mozilla-services/socorro/commit/d442a4df44a2be121a0ad35a7c3151afc885263a
Merge pull request #4332 from willkg/1435551-crash-data-and-processed-crashes

fix bug 1299465, 1435551 - remove CrashData classes and stop saving to processed_crashes_* tables