Closed Bug 1299474 Opened 7 years ago Closed 7 years ago

Baldr: MIPS: Enable unaligned accesses

Categories

(Core :: JavaScript Engine: JIT, defect, P5)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox51 --- wontfix
firefox52 --- fixed

People

(Reporter: bbouvier, Assigned: hev)

References

Details

Attachments

(1 file)

0001-Bug-1299474-Baldr-MIPS-Enable-unaligned-accesses.-r-.patch
726 bytes, patch
bbouvier
: review+
Details | Diff | Splinter Review 
As shows a quick build of the mips simulator:

js> wasmIsSupported()
false

This is due to SupportsUnalignedAccesses returning false:
http://searchfox.org/mozilla-central/source/js/src/jit/mips-shared/Assembler-mips-shared.h#1226

Forcing this to "return true" shows some test failures when running jit_tests.py on the wasm target:

$ jit_tests.py $JS wasm
[104| 53|  0|  0] 100% ==============================================>|  59.9s

There are 104 failures, which sounds unexpected (even considering the baseline compiler has not been implemented yet).

CC'ing our MIPS contributors, to make sure they're aware of this, in case they want to take a look :)
(In reply to Benjamin Bouvier [:bbouvier] from comment #0)
> As shows a quick build of the mips simulator:
> 
> js> wasmIsSupported()
> false
> 
> This is due to SupportsUnalignedAccesses returning false:
> http://searchfox.org/mozilla-central/source/js/src/jit/mips-shared/Assembler-
> mips-shared.h#1226
> 
> Forcing this to "return true" shows some test failures when running
> jit_tests.py on the wasm target:
> 
> $ jit_tests.py $JS wasm
> [104| 53|  0|  0] 100% ==============================================>| 
> 59.9s
> 
> There are 104 failures, which sounds unexpected (even considering the
> baseline compiler has not been implemented yet).
> 
> CC'ing our MIPS contributors, to make sure they're aware of this, in case
> they want to take a look :)

Got it, thank you :)
Assignee: nobody → r
Status: NEW → ASSIGNED
Summary: Baldr: MIPS support is disabled → Baldr: MIPS: Enable unaligned accesses
Depends on: 1290812
Depends on: 1303690
Comment on attachment 8793807 [details] [diff] [review]
0001-Bug-1299474-Baldr-MIPS-Enable-unaligned-accesses.-r-.patch

Review of attachment 8793807 [details] [diff] [review]:
-----------------------------------------------------------------

\o/
Attachment #8793807 - Flags: review?(bbouvier) → review+
Priority: -- → P5
Pushed by r@hev.cc:
https://hg.mozilla.org/integration/mozilla-inbound/rev/241c41e008ca
Baldr: MIPS: Enable unaligned accesses. r=bbouvier
https://hg.mozilla.org/mozilla-central/rev/241c41e008ca
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Mark 51 as won't fix as WebAssembly won't be in 51.
status-firefox51: affected → wontfix
You need to log in before you can comment on or make changes to this bug.