Baldr: MIPS: Enable unaligned accesses

RESOLVED FIXED in Firefox 52

Status

()

P5
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bbouvier, Assigned: hev)

Tracking

Trunk
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 wontfix, firefox52 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
As shows a quick build of the mips simulator:

js> wasmIsSupported()
false

This is due to SupportsUnalignedAccesses returning false:
http://searchfox.org/mozilla-central/source/js/src/jit/mips-shared/Assembler-mips-shared.h#1226

Forcing this to "return true" shows some test failures when running jit_tests.py on the wasm target:

$ jit_tests.py $JS wasm
[104| 53|  0|  0] 100% ==============================================>|  59.9s

There are 104 failures, which sounds unexpected (even considering the baseline compiler has not been implemented yet).

CC'ing our MIPS contributors, to make sure they're aware of this, in case they want to take a look :)
(Assignee)

Comment 1

2 years ago
(In reply to Benjamin Bouvier [:bbouvier] from comment #0)
> As shows a quick build of the mips simulator:
> 
> js> wasmIsSupported()
> false
> 
> This is due to SupportsUnalignedAccesses returning false:
> http://searchfox.org/mozilla-central/source/js/src/jit/mips-shared/Assembler-
> mips-shared.h#1226
> 
> Forcing this to "return true" shows some test failures when running
> jit_tests.py on the wasm target:
> 
> $ jit_tests.py $JS wasm
> [104| 53|  0|  0] 100% ==============================================>| 
> 59.9s
> 
> There are 104 failures, which sounds unexpected (even considering the
> baseline compiler has not been implemented yet).
> 
> CC'ing our MIPS contributors, to make sure they're aware of this, in case
> they want to take a look :)

Got it, thank you :)
(Assignee)

Updated

2 years ago
Assignee: nobody → r
Status: NEW → ASSIGNED
(Assignee)

Updated

2 years ago
Summary: Baldr: MIPS support is disabled → Baldr: MIPS: Enable unaligned accesses
(Assignee)

Updated

2 years ago
Depends on: 1290812
(Assignee)

Updated

2 years ago
Depends on: 1303690
(Assignee)

Comment 2

2 years ago
Created attachment 8793807 [details] [diff] [review]
0001-Bug-1299474-Baldr-MIPS-Enable-unaligned-accesses.-r-.patch
Attachment #8793807 - Flags: review?(bbouvier)
(Reporter)

Comment 3

2 years ago
Comment on attachment 8793807 [details] [diff] [review]
0001-Bug-1299474-Baldr-MIPS-Enable-unaligned-accesses.-r-.patch

Review of attachment 8793807 [details] [diff] [review]:
-----------------------------------------------------------------

\o/
Attachment #8793807 - Flags: review?(bbouvier) → review+
Priority: -- → P5

Comment 4

2 years ago
Pushed by r@hev.cc:
https://hg.mozilla.org/integration/mozilla-inbound/rev/241c41e008ca
Baldr: MIPS: Enable unaligned accesses. r=bbouvier

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/241c41e008ca
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Mark 51 as won't fix as WebAssembly won't be in 51.
status-firefox51: affected → wontfix
You need to log in before you can comment on or make changes to this bug.