Update in-tree libpng to version 1.6.25

RESOLVED FIXED in Firefox 51

Status

()

Core
ImageLib
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Glenn Randers-Pehrson, Assigned: Glenn Randers-Pehrson)

Tracking

(Blocks: 1 bug)

Trunk
mozilla51
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 fixed)

Details

(URL)

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

a year ago
Libpng-1.6.25 is scheduled for release tomorrow 1 September 2016.  It'll be slightly smaller than libpng-1.6.24 and will offer optimized PNG filter functions for MIPS-MSA platforms.
(Assignee)

Updated

a year ago
Assignee: nobody → glennrp+bmo
Status: NEW → ASSIGNED
Depends on: 1291986
(Assignee)

Updated

a year ago
(Assignee)

Comment 1

a year ago
Created attachment 8787443 [details] [diff] [review]
V00 update embedded libpng to version 1.6.25

Update to libpng-1.6.25 except for new MIPS feature.  Try?
Flags: needinfo?(ryanvm)
(In reply to Glenn Randers-Pehrson from comment #1)
> Created attachment 8787443 [details] [diff] [review]
> V00 update embedded libpng to version 1.6.25
> 
> Update to libpng-1.6.25 except for new MIPS feature.  Try?

Looks like your diff is still trying to make MIPS-related changes.

applying v00-1299590-libpng-1.6.25.diff
unable to find 'media/libpng/mips/filter_msa_intrinsics.c' for patching
1 out of 1 hunks FAILED -- saving rejects to file media/libpng/mips/filter_msa_intrinsics.c.rej
unable to find 'media/libpng/mips/linux.c' for patching
1 out of 1 hunks FAILED -- saving rejects to file media/libpng/mips/linux.c.rej
unable to find 'media/libpng/mips/mips_init.c' for patching
1 out of 1 hunks FAILED -- saving rejects to file media/libpng/mips/mips_init.c.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
Flags: needinfo?(ryanvm)
(Assignee)

Updated

a year ago
Blocks: 1299974
(Assignee)

Comment 3

a year ago
Created attachment 8787445 [details] [diff] [review]
V00 update embedded libpng to version 1.6.25

Separate out the MIPS code for another bug.
Attachment #8787443 - Attachment is obsolete: true
(Assignee)

Updated

a year ago
Flags: needinfo?(ryanvm)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=384cb4da819b
Flags: needinfo?(ryanvm)
(Assignee)

Comment 5

a year ago
Comment on attachment 8787445 [details] [diff] [review]
V00 update embedded libpng to version 1.6.25

Try was successful.  R?
Attachment #8787445 - Flags: review?(jmuizelaar)
(Assignee)

Comment 6

a year ago
Created attachment 8788206 [details] [diff] [review]
v02-1299590-libpng-1.6.25

Removed duplicate paragraph from LICENSE and png.h
Attachment #8787445 - Attachment is obsolete: true
Attachment #8787445 - Flags: review?(jmuizelaar)
Attachment #8788206 - Flags: review?(seth.bugzilla)
(Assignee)

Updated

a year ago
Attachment #8788206 - Flags: review?(tnikkel)
Comment on attachment 8788206 [details] [diff] [review]
v02-1299590-libpng-1.6.25

>diff --git a/media/libpng/png.h.rej b/media/libpng/png.h.rej
>--- a/media/libpng/png.h.rej	1969-12-31 19:00:00.000000000 -0500
>+++ b/media/libpng/png.h.rej	2016-09-05 11:56:10.277027918 -0400

I'm guessing we don't want to include this .rej file. Please remove before landing.
Attachment #8788206 - Flags: review?(tnikkel) → review+
(Assignee)

Comment 8

a year ago
Created attachment 8789025 [details] [diff] [review]
V03 update embedded libpng to version 1.6.25

Removed *.rej file
Attachment #8788206 - Attachment is obsolete: true
Attachment #8788206 - Flags: review?(seth.bugzilla)
(Assignee)

Updated

a year ago
Keywords: checkin-needed
(Assignee)

Comment 9

a year ago
Please transfer r+ to the V03 patch, thanks.
Flags: needinfo?(tnikkel)
Flags: needinfo?(tnikkel)
Attachment #8789025 - Flags: review+

Comment 10

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fad88c31ba2d
Update in-tree libpng to version 1.6.25. r=tn
Keywords: checkin-needed

Comment 11

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fad88c31ba2d
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
(Assignee)

Updated

a year ago
Blocks: 1293911
(Assignee)

Updated

a year ago
Blocks: 1311776
You need to log in before you can comment on or make changes to this bug.