Closed Bug 1299590 Opened 4 years ago Closed 4 years ago

Update in-tree libpng to version 1.6.25

Categories

(Core :: ImageLib, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: glennrp+bmo, Assigned: glennrp+bmo)

References

()

Details

Attachments

(1 file, 3 obsolete files)

Libpng-1.6.25 is scheduled for release tomorrow 1 September 2016.  It'll be slightly smaller than libpng-1.6.24 and will offer optimized PNG filter functions for MIPS-MSA platforms.
Assignee: nobody → glennrp+bmo
Status: NEW → ASSIGNED
Depends on: 1291986
Update to libpng-1.6.25 except for new MIPS feature.  Try?
Flags: needinfo?(ryanvm)
(In reply to Glenn Randers-Pehrson from comment #1)
> Created attachment 8787443 [details] [diff] [review]
> V00 update embedded libpng to version 1.6.25
> 
> Update to libpng-1.6.25 except for new MIPS feature.  Try?

Looks like your diff is still trying to make MIPS-related changes.

applying v00-1299590-libpng-1.6.25.diff
unable to find 'media/libpng/mips/filter_msa_intrinsics.c' for patching
1 out of 1 hunks FAILED -- saving rejects to file media/libpng/mips/filter_msa_intrinsics.c.rej
unable to find 'media/libpng/mips/linux.c' for patching
1 out of 1 hunks FAILED -- saving rejects to file media/libpng/mips/linux.c.rej
unable to find 'media/libpng/mips/mips_init.c' for patching
1 out of 1 hunks FAILED -- saving rejects to file media/libpng/mips/mips_init.c.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
Flags: needinfo?(ryanvm)
Blocks: 1299974
Separate out the MIPS code for another bug.
Attachment #8787443 - Attachment is obsolete: true
Flags: needinfo?(ryanvm)
Comment on attachment 8787445 [details] [diff] [review]
V00 update embedded libpng to version 1.6.25

Try was successful.  R?
Attachment #8787445 - Flags: review?(jmuizelaar)
Attached patch v02-1299590-libpng-1.6.25 (obsolete) — Splinter Review
Removed duplicate paragraph from LICENSE and png.h
Attachment #8787445 - Attachment is obsolete: true
Attachment #8787445 - Flags: review?(jmuizelaar)
Attachment #8788206 - Flags: review?(seth.bugzilla)
Attachment #8788206 - Flags: review?(tnikkel)
Comment on attachment 8788206 [details] [diff] [review]
v02-1299590-libpng-1.6.25

>diff --git a/media/libpng/png.h.rej b/media/libpng/png.h.rej
>--- a/media/libpng/png.h.rej	1969-12-31 19:00:00.000000000 -0500
>+++ b/media/libpng/png.h.rej	2016-09-05 11:56:10.277027918 -0400

I'm guessing we don't want to include this .rej file. Please remove before landing.
Attachment #8788206 - Flags: review?(tnikkel) → review+
Removed *.rej file
Attachment #8788206 - Attachment is obsolete: true
Attachment #8788206 - Flags: review?(seth.bugzilla)
Keywords: checkin-needed
Please transfer r+ to the V03 patch, thanks.
Flags: needinfo?(tnikkel)
Flags: needinfo?(tnikkel)
Attachment #8789025 - Flags: review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fad88c31ba2d
Update in-tree libpng to version 1.6.25. r=tn
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fad88c31ba2d
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Blocks: 1293911
Blocks: 1311776
You need to log in before you can comment on or make changes to this bug.