1299628 - Replace Topsite tests with new ones for ActivityStream

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect, P1)

Description

[Farhan Patel [:farhan]]

There are tests in both UItests/ and XCUITests/ that work with topsites. Make sure all the tests are working with the new Activity Stream panel. 

Also AS is not enabled on iPad so the tests need to take that into account too.

Comment 1

[Farhan Patel [:farhan]]

Attachment: Pull Request

This will be one of many PR's to add tests to AS. But first lets get the old tests working to get builds passing.

Comment 2

[Stephan Leroux [:sleroux]]

Is the goal to move towards using XCUITests for new integration tests?

Comment 3

[Farhan Patel [:farhan]]

Yea, I've been trying to write more and more tests with XCUITests. It still has its quirks so I understand if the team doesn't want to use it. And because there are no external dependencies I think having it alongside KiF is fine.

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 8791010 [details] [review]
Pull Request

Fixes look good, but the accessibility labels need to be tweaked.

Comment 5

[Brian Nicholson (:bnicholson)]

Comment on attachment 8791010 [details] [review]
Pull Request

Looks good! It'd be nice if we could also fix accessibility for the cell pagination while tweaking this stuff.

Comment 6

[Farhan Patel [:farhan]]

master f4f90b441fe53255e17649618db88d15fc7c8722