Add back the missing timeout protection back to |VideoTrackEncoder::Init|.

RESOLVED FIXED in Firefox 51

Status

()

P1
normal
Rank:
13
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ctai, Assigned: ctai)

Tracking

unspecified
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

This is a regression in Bug 1201363. Got to add back the timeout protection.

Updated

2 years ago
Rank: 13
Priority: -- → P1
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8787088 [details]
Bug 1299714 - Add back the missing timeout protection back to |VideoTrackEncoder::Init|.

https://reviewboard.mozilla.org/r/75946/#review73964

Seems like we used to get the track rate from the graph rate, but now we're always defaulting to the cubeb preferred rate. Is this correct?
Attachment #8787088 - Flags: review?(pehrson) → review+
(Assignee)

Comment 3

2 years ago
mozreview-review-reply
Comment on attachment 8787088 [details]
Bug 1299714 - Add back the missing timeout protection back to |VideoTrackEncoder::Init|.

https://reviewboard.mozilla.org/r/75946/#review73964

The trackRate is for the computing of timeout time for the init function. So I think it is fine for the defaulting rate. If you think that might be issue, we might need a listener for GraphRate change? How do you think?

Comment 4

2 years ago
mozreview-review-reply
Comment on attachment 8787088 [details]
Bug 1299714 - Add back the missing timeout protection back to |VideoTrackEncoder::Init|.

https://reviewboard.mozilla.org/r/75946/#review73964

I just wanted to make sure you had looked into it since I noticed it was different from the original implementation. I don't think graph rate can change, but it could perhaps be different (now or in the future) from the cubeb preferred rate?
(In reply to Andreas Pehrson [:pehrsons] (Telenor) from comment #4)
> Comment on attachment 8787088 [details]
> Bug 1299714 - Add back the missing timeout protection back to
> |VideoTrackEncoder::Init|.
> 
> https://reviewboard.mozilla.org/r/75946/#review73964
> 
> I just wanted to make sure you had looked into it since I noticed it was
> different from the original implementation. I don't think graph rate can
> change, but it could perhaps be different (now or in the future) from the
> cubeb preferred rate?

Per talk with Andreas in irc, some misunderstanding about where the track rate come from.
The track rate come from below line not cubeb default rate.
http://searchfox.org/mozilla-central/source/dom/media/MediaRecorder.cpp#477

The cubeb default rate is for test case only.
Keywords: checkin-needed
Wait for jesup's review.
Keywords: checkin-needed

Comment 7

2 years ago
mozreview-review
Comment on attachment 8787088 [details]
Bug 1299714 - Add back the missing timeout protection back to |VideoTrackEncoder::Init|.

https://reviewboard.mozilla.org/r/75946/#review74594
Attachment #8787088 - Flags: review?(rjesup) → review+
Keywords: checkin-needed

Comment 8

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e42bbde139a3
Add back the missing timeout protection back to |VideoTrackEncoder::Init|. r=jesup,pehrsons
Keywords: checkin-needed

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e42bbde139a3
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.