1299714 - Add back the missing timeout protection back to |VideoTrackEncoder::Init|.

Status: RESOLVED FIXED

(Core :: Audio/Video: Recording, defect, P1)

Description

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

This is a regression in Bug 1201363. Got to add back the timeout protection.

Comment 1

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Bug 1299714 - Add back the missing timeout protection back to |VideoTrackEncoder::Init|.

Review commit: https://reviewboard.mozilla.org/r/75946/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/75946/

Comment 2

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8787088 [details]
Bug 1299714 - Add back the missing timeout protection back to |VideoTrackEncoder::Init|.

https://reviewboard.mozilla.org/r/75946/#review73964

Seems like we used to get the track rate from the graph rate, but now we're always defaulting to the cubeb preferred rate. Is this correct?

Comment 3

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 8787088 [details]
Bug 1299714 - Add back the missing timeout protection back to |VideoTrackEncoder::Init|.

https://reviewboard.mozilla.org/r/75946/#review73964

The trackRate is for the computing of timeout time for the init function. So I think it is fine for the defaulting rate. If you think that might be issue, we might need a listener for GraphRate change? How do you think?

Comment 4

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8787088 [details]
Bug 1299714 - Add back the missing timeout protection back to |VideoTrackEncoder::Init|.

https://reviewboard.mozilla.org/r/75946/#review73964

I just wanted to make sure you had looked into it since I noticed it was different from the original implementation. I don't think graph rate can change, but it could perhaps be different (now or in the future) from the cubeb preferred rate?

Comment 5

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

(In reply to Andreas Pehrson [:pehrsons] (Telenor) from comment #4)
> Comment on attachment 8787088 [details]
> Bug 1299714 - Add back the missing timeout protection back to
> |VideoTrackEncoder::Init|.
> 
> https://reviewboard.mozilla.org/r/75946/#review73964
> 
> I just wanted to make sure you had looked into it since I noticed it was
> different from the original implementation. I don't think graph rate can
> change, but it could perhaps be different (now or in the future) from the
> cubeb preferred rate?

Per talk with Andreas in irc, some misunderstanding about where the track rate come from.
The track rate come from below line not cubeb default rate.
http://searchfox.org/mozilla-central/source/dom/media/MediaRecorder.cpp#477

The cubeb default rate is for test case only.

Comment 6

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Wait for jesup's review.

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8787088 [details]
Bug 1299714 - Add back the missing timeout protection back to |VideoTrackEncoder::Init|.

https://reviewboard.mozilla.org/r/75946/#review74594

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e42bbde139a3
Add back the missing timeout protection back to |VideoTrackEncoder::Init|. r=jesup,pehrsons

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e42bbde139a3