1299738 - SourceSurfaceIncompatible crash in mozilla::gfx::GetBitmapForSurface

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

This bug was filed from the Socorro interface and is 
report bp-7f0c305d-fc17-420f-ae1f-b03732160901.
=============================================================

Low volume crash at [1], SourceSurfaceIncompatible: "Non-Skia SourceSurfaces need to be DataSourceSurfaces". Crashes seem to have started with the 8-27 nightly (with regression range [2]), and there are consistently a few crashes per nightly.

[1] https://hg.mozilla.org/mozilla-unified/annotate/1a5b53a831e5/gfx/2d/DrawTargetSkia.cpp#l215

[2] https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a551f534773cf2d6933f78ce7d82a7a33a99643e&tochange=c724ae8bb7b867b6bc65efa1049c0322457ff4b0

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: warn instead of crash if DrawTargetSkia's GetBitmapForSurface fails

We have stale SourceSurfaceD2D1s lying around temporarily during a device reset till the browser notices to clean them up.

These will fail to map/convert to data surfaces. Normally this was not a problem in DrawTargetD2D1 or DrawTargetCairo since we would not crash, but only just bail out or at worst warn.

So, we're a little overzealous in always crashing in this case in Skia. So let's just warn here to be consistent.

Also clean up some old cruft that is unnecessary in DrawTargetSkia checking SourceSurface types.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/657ba2f2611c
warn instead of crash if DrawTargetSkia's GetBitmapForSurface fails. r=mchang

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/657ba2f2611c