If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

talos pageloader friendly summary output needs a proper sort

NEW
Unassigned

Status

Testing
Talos
a year ago
a year ago

People

(Reporter: jmaher, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [talos_wishlist])

(Reporter)

Description

a year ago
https://bugzilla.mozilla.org/show_bug.cgi?id=1298230#c12

(In reply to Boris Zbarsky [:bz] from comment #10)
> Oh, and as far as the testcase goes, please replace the `sort()` calls with
> `sort((a,b) => a-b)` because otherwise you're sorting by alphabetical order
> of the strings, which can do weird things near powers-of-10 boundaries.

Interesting, I grabbed this code from talos: https://dxr.mozilla.org/mozilla-central/source/testing/talos/talos/pageloader/chrome/report.js#97.  Joel, does this median calculation get used for tracking / reporting times?  Because it is error prone in the case of [1,2,3,4,5,6,7,8,9,10,11].sort().


lets use a proper sort in pageloader.

As a note, when we update pageloader, we will need to re-sign the addon:
https://wiki.mozilla.org/EngineeringProductivity/HowTo/SignExtensions
You need to log in before you can comment on or make changes to this bug.