Closed
Bug 1299758
Opened 9 years ago
Closed 6 years ago
talos pageloader friendly summary output needs a proper sort
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(Not tracked)
RESOLVED
INACTIVE
People
(Reporter: jmaher, Unassigned)
Details
(Whiteboard: [talos_wishlist])
https://bugzilla.mozilla.org/show_bug.cgi?id=1298230#c12
(In reply to Boris Zbarsky [:bz] from comment #10)
> Oh, and as far as the testcase goes, please replace the `sort()` calls with
> `sort((a,b) => a-b)` because otherwise you're sorting by alphabetical order
> of the strings, which can do weird things near powers-of-10 boundaries.
Interesting, I grabbed this code from talos: https://dxr.mozilla.org/mozilla-central/source/testing/talos/talos/pageloader/chrome/report.js#97. Joel, does this median calculation get used for tracking / reporting times? Because it is error prone in the case of [1,2,3,4,5,6,7,8,9,10,11].sort().
lets use a proper sort in pageloader.
As a note, when we update pageloader, we will need to re-sign the addon:
https://wiki.mozilla.org/EngineeringProductivity/HowTo/SignExtensions
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INACTIVE
You need to log in
before you can comment on or make changes to this bug.
Description
•