[Static Analysis][ Missing comma in a string array initialisation] In declaration of sSupportedRelValues

RESOLVED FIXED in Firefox 51

Status

()

defect
RESOLVED FIXED
3 years ago
2 months ago

People

(Reporter: andi, Assigned: andi)

Tracking

(Blocks 1 bug, {coverity})

Trunk
mozilla51
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 fixed)

Details

(Whiteboard: CID 1365150)

Attachments

(1 attachment)

The Static Analysis tool Coverity detected that after the first argument initialisation in sSupportedRelValues the comma is omitted thus leading to a concatenation of the first item.

>>static const DOMTokenListSupportedToken sSupportedRelValues[] = {
>>  // Keep this in sync with ToLinkMask in nsStyleLinkElement.cpp.
>>  // "import" must come first because it's conditional.
>>  "import"
>>  "prefetch",
>>  "dns-prefetch",
>>  "stylesheet",
>>  "next",
>>  "alternate",
>>  "preconnect",
>>  "icon",
>>  "search",
>>  nullptr
>>};
Comment hidden (mozreview-request)

Comment 2

3 years ago
mozreview-review
Comment on attachment 8787143 [details]
Bug 1299762 - prevent string concatanation in string list initialization.

https://reviewboard.mozilla.org/r/76006/#review74090
Attachment #8787143 - Flags: review?(amarchesini) → review+

Comment 3

3 years ago
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9f6df7f965bf
prevent string concatanation in string list initialization. r=baku

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9f6df7f965bf
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.