Closed
Bug 1299762
Opened 7 years ago
Closed 7 years ago
[Static Analysis][ Missing comma in a string array initialisation] In declaration of sSupportedRelValues
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: andi, Assigned: andi)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: CID 1365150)
Attachments
(1 file)
The Static Analysis tool Coverity detected that after the first argument initialisation in sSupportedRelValues the comma is omitted thus leading to a concatenation of the first item.
>>static const DOMTokenListSupportedToken sSupportedRelValues[] = {
>> // Keep this in sync with ToLinkMask in nsStyleLinkElement.cpp.
>> // "import" must come first because it's conditional.
>> "import"
>> "prefetch",
>> "dns-prefetch",
>> "stylesheet",
>> "next",
>> "alternate",
>> "preconnect",
>> "icon",
>> "search",
>> nullptr
>>};
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8787143 [details] Bug 1299762 - prevent string concatanation in string list initialization. https://reviewboard.mozilla.org/r/76006/#review74090
Attachment #8787143 -
Flags: review?(amarchesini) → review+
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9f6df7f965bf prevent string concatanation in string list initialization. r=baku
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9f6df7f965bf
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
|
||
Updated•4 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•