1299762 - [Static Analysis][ Missing comma in a string array initialisation] In declaration of sSupportedRelValues

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity detected that after the first argument initialisation in sSupportedRelValues the comma is omitted thus leading to a concatenation of the first item.

>>static const DOMTokenListSupportedToken sSupportedRelValues[] = {
>>  // Keep this in sync with ToLinkMask in nsStyleLinkElement.cpp.
>>  // "import" must come first because it's conditional.
>>  "import"
>>  "prefetch",
>>  "dns-prefetch",
>>  "stylesheet",
>>  "next",
>>  "alternate",
>>  "preconnect",
>>  "icon",
>>  "search",
>>  nullptr
>>};

Comment 1

[Andi [:andi]]

Attachment: Bug 1299762 - prevent string concatanation in string list initialization.

Review commit: https://reviewboard.mozilla.org/r/76006/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76006/

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8787143 [details]
Bug 1299762 - prevent string concatanation in string list initialization.

https://reviewboard.mozilla.org/r/76006/#review74090

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f6df7f965bf
prevent string concatanation in string list initialization. r=baku

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9f6df7f965bf