1299866 - [FlyWeb] mDNS services discovered remain after network change

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Justin D'Arcangelo [:justindarc]]

In the JS mDNS implementation, services discovered will remain "cached" even when the user changes to a different network. Eventually, after the cache timeout period, the list of discovered services will correct itself. However, this is a very poor UX since the user may likely assume that the list of discovered services will change immediately when switching to a new WiFi network.

Comment 1

[Justin D'Arcangelo [:justindarc]]

Attachment: bug1299866.diff

Comment 2

[Kannan Vijayan [:djvj]]

Comment on attachment 8787288 [details] [diff] [review]
bug1299866.diff

Review of attachment 8787288 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/dns/mdns/libmdns/fallback/MulticastDNS.jsm
@@ +98,5 @@
>      this.advertiseTimer = undefined;
>    }
>  }
>  
> +let _observerService = Cc["@mozilla.org/observer-service;1"]

No underscore here.  This is a regular global, let's call it ObserverService.

Comment 3

[Justin D'Arcangelo [:justindarc]]

Rebasing this patch on top of Bug 1296464 before addressing review comments.

Comment 4

[Justin D'Arcangelo [:justindarc]]

Attachment: bug1299866.patch

Rebased on latest patch in Bug 1296464. Carrying R+ forward.

Comment 5

[Justin D'Arcangelo [:justindarc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c500c6833873

Comment 6

[Justin D'Arcangelo [:justindarc]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d3d45f7fa087c2c15742bd572ec45e01d1151911
Bug 1299866 - [FlyWeb] mDNS services discovered remain after network change;r=djvj

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d3d45f7fa087