The default bug view has changed. See this FAQ.

[FlyWeb] mDNS services discovered remain after network change

RESOLVED FIXED in Firefox 52

Status

()

Core
Networking
RESOLVED FIXED
7 months ago
6 months ago

People

(Reporter: justindarc, Assigned: justindarc)

Tracking

(Blocks: 1 bug)

unspecified
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

(Whiteboard: [necko-active])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 months ago
In the JS mDNS implementation, services discovered will remain "cached" even when the user changes to a different network. Eventually, after the cache timeout period, the list of discovered services will correct itself. However, this is a very poor UX since the user may likely assume that the list of discovered services will change immediately when switching to a new WiFi network.
(Assignee)

Updated

7 months ago
Assignee: nobody → jdarcangelo
Blocks: 1228662
(Assignee)

Comment 1

7 months ago
Created attachment 8787288 [details] [diff] [review]
bug1299866.diff
Attachment #8787288 - Flags: review?(kvijayan)
(Assignee)

Updated

7 months ago
Status: NEW → ASSIGNED
Whiteboard: [necko-active]
Comment on attachment 8787288 [details] [diff] [review]
bug1299866.diff

Review of attachment 8787288 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/dns/mdns/libmdns/fallback/MulticastDNS.jsm
@@ +98,5 @@
>      this.advertiseTimer = undefined;
>    }
>  }
>  
> +let _observerService = Cc["@mozilla.org/observer-service;1"]

No underscore here.  This is a regular global, let's call it ObserverService.
Attachment #8787288 - Flags: review?(kvijayan) → review+
(Assignee)

Comment 3

7 months ago
Rebasing this patch on top of Bug 1296464 before addressing review comments.
Depends on: 1296464
(Assignee)

Comment 4

6 months ago
Created attachment 8792555 [details] [diff] [review]
bug1299866.patch

Rebased on latest patch in Bug 1296464. Carrying R+ forward.
Attachment #8787288 - Attachment is obsolete: true
Attachment #8792555 - Flags: review+
(Assignee)

Comment 5

6 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c500c6833873
(Assignee)

Comment 6

6 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3d45f7fa087c2c15742bd572ec45e01d1151911
Bug 1299866 - [FlyWeb] mDNS services discovered remain after network change;r=djvj

Comment 7

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d3d45f7fa087
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.