Bump the content process leak threshold on OSX

RESOLVED WONTFIX

Status

defect
RESOLVED WONTFIX
3 years ago
3 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

unspecified
mozilla51
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox49 fixed, firefox50 fixed, firefox51 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
Apparently the content process leak has crept up enough that it frequently exceeds the leak threshold, but only on OSX. I'll increase it a little to at least avoid these oranges.
Assignee

Comment 1

3 years ago
Looks like the leak is always 10216 bytes.


   0 |TOTAL                |  20    10216| 6497490       62|
  34 |BasicContainerLayer  | 712     1424|      40        2|
  35 |BasicImplData        |  16       48|      76        3|
  36 |BasicLayerManager    | 232      232|      19        1|
  37 |BasicPaintedLayer    | 720      720|      36        1|
 105 |CompositableClient   |  48       96|     112        2|
 134 |ContainerLayer       | 696     1392|      68        2|
 209 |DrawTargetSkia       | 168      336|    1023        2|
 346 |Layer                | 648     3888|     292        6|
 347 |LayerManager         | 176      176|      23        1|
 348 |LayerManagerData     |  72       72|      11        1|
 385 |Mutex                |  32       64|    1615        2|
 521 |RotatedContentBuffer | 112      112|      36        1|
 593 |TextEventDispatcher  |  96       96|       5        1|
 594 |TextInputHandlerBase | 112      112|       5        1|
 799 |nsBaseWidget         | 336      672|       8        2|
 858 |nsCocoaWindow        | 512      512|       3        1|
1276 |nsTArray_base        |   8      264| 1301444       33|
Assignee

Comment 3

3 years ago
I bumped the threshold to 12000 bytes on OSX, as that will give us a little headroom when this leak inevitably grows. I tested locally on OSX and Mochitest at least still runs.

Comment 4

3 years ago
mozreview-review
Comment on attachment 8787315 [details]
Bug 1299871 - Increase leak threshold on OS X to paper over increased layers leak.

https://reviewboard.mozilla.org/r/76122/#review74142
Attachment #8787315 - Flags: review?(erahm) → review+

Comment 5

3 years ago
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/de84b1059f7f
Increase leak threshold on OS X to paper over increased layers leak. r=erahm

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/de84b1059f7f
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Whiteboard: [checkin-needed-aurora][checkin-needed-beta]
m-c tip is still hitting bug 1293324. Any idea why?
Flags: needinfo?(continuation)
Assignee

Comment 9

3 years ago
Oh, I see, I misread the failure. It is actually a main process leak, not a content process leak. That is bad, as our current main process limit is 0. So I suppose this should be backed out and WONTFIXed.
Flags: needinfo?(continuation)
Assignee

Comment 10

3 years ago
Backed out because it doesn't fix anything:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ebe49166a751

It won't harm anything to leave it on Aurora and Beta.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee

Updated

3 years ago
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.