129988 - No advance to next message if message pane focused

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P1)

Description

[Victor Kazmirenko]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.9+)
Gecko/20020309
BuildID:    2002030908

In Messenger while rading news (I use offline) if focus placed on message body
(right-bottom pane in 3-pane view) space bar and 'n' do not advance to next
message. However, 'Next' button on toolbar works. When subjects pane is focused
(right-top) then both shortcuts work.

Reproducible: Always
Steps to Reproduce:
1.Go to newsgroup that contains unread messages
2.Select message body pane
3.Press 'n' or space bar

Actual Results:  Message scrolls to the end but there no advance to next unread. 

Expected Results:  Next unread message should be displayed when current is
screolled to the end.

Comment 1

[(not reading, please use [e-mail] instead)]

thanks for the bug, victor.

I'm pretty sure I caused this regression with my checkin for #128101 

I'll tackle this first thing monday morning.

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: fix, boy do I suck ass for this.

Comment 3

[(not reading, please use [e-mail] instead)]

I've tested and made sure that his fix doesn't break the fix for #128101

I'll go seek reviews.

Comment 4

[Jean-Francois Ducarroz]

Comment on attachment 73537 [details] [diff] [review]
fix, boy do I suck ass for this.

R=ducarroz

Comment 5

[David :Bienvenu]

Comment on attachment 73537 [details] [diff] [review]
fix, boy do I suck ass for this.

sr=bienvenu

Comment 6

[(not reading, please use [e-mail] instead)]

Attachment: simpler patch, as suggested by ssu. I still suck ass.

Comment 7

[Sean Su]

Comment on attachment 73539 [details] [diff] [review]
simpler patch, as suggested by ssu.  I still suck ass.

r=ssu

Comment 8

[David :Bienvenu]

Comment on attachment 73539 [details] [diff] [review]
simpler patch, as suggested by ssu.  I still suck ass.

sr=bienvenu

Comment 9

[Brendan Eich [:brendan]]

Comment on attachment 73539 [details] [diff] [review]
simpler patch, as suggested by ssu.  I still suck ass.

a=[e-mail] for the 1.0 trunk.

Who is still using tabs?  *shudder*

/be

Comment 10

[(not reading, please use [e-mail] instead)]

the tabs are fixed locally, that patch is -uw.

fixed.

Comment 11

[Victor Kazmirenko]

Could anybody kindly explain me what is the meaning of 'Resolution: fixed'? Am I
right that fix is included in following nightly? If so 2002031103 has the same
problem...

Comment 12

[(not reading, please use [e-mail] instead)]

resolved fixed means I checked in the fix.

you'll have to wait for the next build that includes this fix.

in this case, that's tomorrow's build.

Comment 13

[Sean Su]

*** Bug 130142 has been marked as a duplicate of this bug. ***

Comment 14

[laurel]

OK using mar14 commercial trunk: win98, mac OS 10.1, linuxrh6.2