1299922 - Fennec will often show a flash of the contents of the previous tab when switching tabs

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Randall Barker [:rbarker]]

STR:

1) Open 2 tabs with web content.
2) Switch between tabs.

Expected: Content of selected tab is displayed.
Actual: The Content of the previous frame is displayed for a very brief moment causing the content to appear to flash.

It looks to me like content of the selected tab needs to be recomposited or at least cleared sooner and that the flash of previous content is just what was last composited to the surface.

Comment 1

[Randall Barker [:rbarker]]

Attachment: Example of content flash.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

I've seen this a lot as well, we should definitely fix.

Comment 3

[Randall Barker [:rbarker]]

I did a mozregression and found Bug 1291373 to be the cause.

Comment 4

[Randall Barker [:rbarker]]

This is the change that caused the regression:

https://bugzilla.mozilla.org/attachment.cgi?id=8780258&action=diff#a/mobile/android/geckoview/src/main/java/org/mozilla/gecko/gfx/LayerRenderer.java_sec10

Comment 5

[Randall Barker [:rbarker]]

Attachment: 0001-Bug-1299922-Keep-surface-covered-until-it-has-been-painted-when-switching-tabs-in-Fennec-r-jchen-16090116-8baf8db.patch

Comment 6

[Randall Barker [:rbarker]]

Attachment: 0001-Bug-1299922-Keep-surface-covered-until-it-has-been-painted-when-switching-tabs-in-Fennec-r-jchen-16090216-9ae6b95.patch

Updated to reflect updates in Bug 1297853.
Cary forward r+ from :jchen

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb90834c4f10
Keep surface covered until it has been painted when switching tabs in Fennec r=jchen

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eb90834c4f10

Comment 9

[Sorina Florean [:sflorean]]

Verified as fixed on 51 Beta 9;
Device: Nexus 9 (Android 7.0) and Asus Transformer Pad (Android 4.2.1).