129999 - needs ansi-1251 font support in nsFontMetricsGTK/nsFontMetricsXlib

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Masaki Katakai]

Soalris ANSI1251 locale provide the following fonts,

-monotype-times-bold-i-normal--0-0-0-0-p-0-ansi-1251

However, ansi-1251 is not defined in nsFontMetricsGTK.cpp.
Please add the entry.

Comment 1

[Masaki Katakai]

Attachment: add entry

Comment 2

[Roy Yokoyama]

It's better assign to person who knows Solaris better;
bstell..... (????) but the patch looks good.

Comment 3

[kill this account]

I believe the list is in alphabetic order. Could this entry be inserted between
"adobe-fontspecific" and "big5-0"?

403 static nsFontCharSetMap gCharSetMap[] =
404 {
405   { "-ascii",             &FLG_NONE,    &Unknown       },
406   { "-ibm pc",            &FLG_NONE,    &Unknown       },
407   { "adobe-fontspecific", &FLG_NONE,    &Special       },
+     { "ansi-1251",          &FLG_NONE,    &CP1251        },
408   { "big5-0",             &FLG_ZHTW,    &Big5          },

Comment 4

[kill this account]

move target to 1.1

Comment 5

[kill this account]

Katakai: I hope it is okay if I assign this to you.

Comment 6

[Roland Mainz]

Two issues:
- No test case (can anyone please file one ?)
- Xlib fontmetrics code isn't patched (I file a patch for that in a few hours)

Comment 7

[Roland Mainz]

Attachment: Patch for 2002-03-23-08-trunk (both GTK+ and Xlib fontmetrics)

Comment 8

[Roland Mainz]

katakai:
- Should I take this bug ?
- Do you have a testcase ?

Comment 9

[Roland Mainz]

Taking...

Comment 10

[Roland Mainz]

Requesting r=/sr=/a= ...

Comment 11

[Masaki Katakai]

Thanks for taking this, Roland.

But please see the comments of #3. Please put this after
"adobe-fontspecific".

Fix that and you have r=katakai.

Comment 12

[Masaki Katakai]

Test case:

1. Please login to Solaris ANSI1251 locale

2. Edit->Prefs->Font
   ansi-1251 isn't show up

3. try to browse russian page
   glyphs are very big because there is no iso8859-5 fonts
   in ANSI1251 locale of Solaris.

Comment 13

[Roland Mainz]

Attachment: Patch for 2002-04-05-08-trunk to match r=katakai

Comment 14

[Marc Attinasi]

Comment on attachment 78129 [details] [diff] [review]
Patch for 2002-04-05-08-trunk to match r=katakai

sr=attinasi

Comment 15

[Asa Dotzler [:asa]]

Comment on attachment 78129 [details] [diff] [review]
Patch for 2002-04-05-08-trunk to match r=katakai

a=asa (on behalf of drivers) for checkin to the 1.0 branch

Comment 16

[timeless]

fix checked in to trunk and branch

Comment 17

[Asa Dotzler [:asa]]

adding fixed1.0.0 keyword (branch resolution). This bug has comments saying it
was fixed on the 1.0 branch and a bonsai checkin comment that agrees. To verify
the bug has been fixed on the 1.0 branch please replace the fixed1.0.0 keyword
with verified1.0.0.

Comment 18

[Roland Mainz]

katakai:
Can you verify for both "trunk" and "1.0-branch" (see asa's comment #17), please
?

Comment 19

[Masaki Katakai]

verified on RC1.