1299997 - Crash: java.lang.NoClassDefFoundError: java.nio.charset.StandardCharsets at org.mozilla.gecko.sync.repositories.uploaders.RecordUploadRunnable.<clinit>(RecordUploadRunnable.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect, P1)

Description

[:Grisha Kruglov]

Caused by the new atomic uploads (see Bug 1253111).

java.nio.charset.StandardCharsets is API19+, so devices below that are crashing when trying to sync.

Comment 1

[:Grisha Kruglov]

Attachment: Bug 1299997 - Can't use API19+ StandardCharsets

Review commit: https://reviewboard.mozilla.org/r/76220/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76220/

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8787471 [details]
Bug 1299997 - Can't use API19+ StandardCharsets

https://reviewboard.mozilla.org/r/76220/#review74286

::: mobile/android/services/src/main/java/org/mozilla/gecko/sync/repositories/uploaders/RecordUploadRunnable.java:31
(Diff revision 1)
>   * Responsible for creating and posting a <code>SyncStorageRequest</code> request object.
>   */
>  public class RecordUploadRunnable implements Runnable {
>      public final String LOG_TAG = "RecordUploadRunnable";
>  
> -    public final static byte[] RECORDS_START = "[".getBytes(StandardCharsets.UTF_8);
> +    public final static byte[] RECORDS_START = "[".getBytes(Charset.forName("UTF-8"));

Even better:

```
= { 91 };   // [ in UTF-8
= { 44 };   // , in UTF-8
= { 93 };   // ] in UTF-8
```

and save the import and the work.

Comment 3

[:Grisha Kruglov]

Comment on attachment 8787471 [details]
Bug 1299997 - Can't use API19+ StandardCharsets

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/76220/diff/1-2/

Comment 4

[:Grisha Kruglov]

Comment on attachment 8787471 [details]
Bug 1299997 - Can't use API19+ StandardCharsets

https://reviewboard.mozilla.org/r/76220/#review74286

> Even better:
> 
> ```
> = { 91 };   // [ in UTF-8
> = { 44 };   // , in UTF-8
> = { 93 };   // ] in UTF-8
> ```
> 
> and save the import and the work.

Heh, sure.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/617559427df0
Can't use API19+ StandardCharsets r=rnewman

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/617559427df0