1300156 - Remove MOZ_SAFE_BROWSING and MOZ_URL_CLASSIFIER from build now that safe browsing configure flag is gone.

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Philip Chee]

(From Bug 336290 comment #0)
> After safebrowsing is fully integrated, remove the configure flag and turn
> on by default in bon echo and trunk.  This is a follow up on to bug 334575
> where the configure flag was added.

Comment 1

[Philip Chee]

Attachment: Patch v1 for Build Config and Installer changes

Comment 2

[Ian Neal]

Comment on attachment 8787701 [details] [diff] [review]
Patch v1 for Build Config and Installer changes

>+++ b/suite/installer/removed-files.in

>-#ifndef MOZ_URL_CLASSIFIER
>-  @DIR_MACOS@components/nsUrlClassifierHashCompleter.js
>-  @DIR_MACOS@components/nsUrlClassifierLib.js
>-  @DIR_MACOS@components/nsUrlClassifierListManager.js
>-#endif

>@@ -697,21 +692,16 @@ Throbber-small.gif
>   @DIR_MACOS@components/nsSuiteDownloadManagerUI.js
>   @DIR_MACOS@components/nsSuiteGlue.js
>   @DIR_MACOS@components/nsTaggingService.js
>   @DIR_MACOS@components/nsTryToClose.js
>   @DIR_MACOS@components/nsTypeAheadFind.js
>   @DIR_MACOS@components/nsUpdateService.js
>   @DIR_MACOS@components/nsUpdateServiceStub.js
>   @DIR_MACOS@components/nsUpdateTimerManager.js
>-  #ifdef MOZ_URL_CLASSIFIER
>-    @DIR_MACOS@components/nsUrlClassifierHashCompleter.js
>-    @DIR_MACOS@components/nsUrlClassifierLib.js
>-    @DIR_MACOS@components/nsUrlClassifierListManager.js
>-  #endif
Shouldn't these be kept as it is #ifdef not #ifndef?

Comment 3

[Ian Neal]

Comment on attachment 8787701 [details] [diff] [review]
Patch v1 for Build Config and Installer changes

As this just syncs with other products do, let's just do it r/a=me

Comment 4

[Philip Chee]

Pushed to comm-central http://hg.mozilla.org/comm-central/rev/cdf8a73f43f7