Closed
Bug 1300182
Opened 9 years ago
Closed 9 years ago
Intermittent browser/components/originattributes/test/browser/browser_firstPartyIsolation.js | "KO" == "OK" -
Categories
(Core :: DOM: Security, defect, P3)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | unaffected |
| firefox51 | --- | fixed |
| firefox52 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: allstars.chh)
References
(Blocks 1 open bug)
Details
(Keywords: intermittent-failure, Whiteboard: [domsecurity-intermittent][tor])
Attachments
(1 file)
|
1001 bytes,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Updated•9 years ago
|
Blocks: 1260931
Component: General → DOM: Security
Flags: needinfo?(allstars.chh)
Product: Firefox → Core
Updated•9 years ago
|
Priority: -- → P3
Whiteboard: [domsecurity-intermittent]
| Comment hidden (Intermittent Failures Robot) |
Updated•9 years ago
|
Blocks: FirstPartyIsolation
Whiteboard: [domsecurity-intermittent] → [domsecurity-intermittent] [tor]
| Comment hidden (Intermittent Failures Robot) |
| Assignee | ||
Updated•9 years ago
|
Assignee: nobody → allstars.chh
Flags: needinfo?(allstars.chh)
| Assignee | ||
Comment 3•9 years ago
|
||
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
| Assignee | ||
Comment 6•9 years ago
|
||
| Assignee | ||
Comment 7•9 years ago
|
||
Hi smaug
I think the intermittent failure happens when the message received in the iframe side has some delay and makes it longer than 1000 mini-seconds, I simply removed the setTimeout to prevent this.
The try result seems good.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2edb8d82d435
Attachment #8798713 -
Flags: review?(bugs)
Comment 8•9 years ago
|
||
Comment on attachment 8798713 [details] [diff] [review]
Patch.
(I can't recall what was the reason for the second postMessage. )
Attachment #8798713 -
Flags: review?(bugs) → review+
| Comment hidden (Intermittent Failures Robot) |
| Assignee | ||
Comment 10•9 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #8)
> Comment on attachment 8798713 [details] [diff] [review]
> Patch.
>
> (I can't recall what was the reason for the second postMessage. )
http://searchfox.org/mozilla-central/source/browser/components/originattributes/test/browser/test_firstParty_postMessage.html
will post a message to test.html, and test.html will reply a message back.
I added setTimeout in case that somehow postMessage cannot work, so the setTimeout could send an error back to the document.
However the timeout value seems caused some intermittent failure, so I simply remove it, and if one day the postMessage didn't work the test will still report error.
Status: NEW → ASSIGNED
Comment 11•9 years ago
|
||
Pushed by yhuang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab0d0603172e
remove setTimeout to prevent intermittent failure. r=smaug
Comment 12•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Updated•9 years ago
|
status-firefox50:
--- → unaffected
status-firefox51:
--- → affected
Whiteboard: [domsecurity-intermittent] [tor] → [domsecurity-intermittent][tor][checkin-needed-aurora]
Comment 13•9 years ago
|
||
| bugherder uplift | ||
Whiteboard: [domsecurity-intermittent][tor][checkin-needed-aurora] → [domsecurity-intermittent][tor]
| Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•