Closed
Bug 1300182
Opened 8 years ago
Closed 8 years ago
Intermittent browser/components/originattributes/test/browser/browser_firstPartyIsolation.js | "KO" == "OK" -
Categories
(Core :: DOM: Security, defect, P3)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox50 | --- | unaffected |
firefox51 | --- | fixed |
firefox52 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: allstars.chh)
References
(Blocks 1 open bug)
Details
(Keywords: intermittent-failure, Whiteboard: [domsecurity-intermittent][tor])
Attachments
(1 file)
1001 bytes,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Filed by: wkocher [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=35189931&repo=mozilla-inbound https://queue.taskcluster.net/v1/task/Ac7kHRjZQqGqw38RIYuTWw/runs/0/artifacts/public%2Flogs%2Flive_backing.log
Updated•8 years ago
|
Blocks: 1260931
Component: General → DOM: Security
Flags: needinfo?(allstars.chh)
Product: Firefox → Core
Updated•8 years ago
|
Priority: -- → P3
Whiteboard: [domsecurity-intermittent]
Comment hidden (Intermittent Failures Robot) |
Updated•8 years ago
|
Blocks: FirstPartyIsolation
Whiteboard: [domsecurity-intermittent] → [domsecurity-intermittent] [tor]
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → allstars.chh
Flags: needinfo?(allstars.chh)
Assignee | ||
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=821e7f4680ab
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 6•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2edb8d82d435
Assignee | ||
Comment 7•8 years ago
|
||
Hi smaug I think the intermittent failure happens when the message received in the iframe side has some delay and makes it longer than 1000 mini-seconds, I simply removed the setTimeout to prevent this. The try result seems good. https://treeherder.mozilla.org/#/jobs?repo=try&revision=2edb8d82d435
Attachment #8798713 -
Flags: review?(bugs)
Comment 8•8 years ago
|
||
Comment on attachment 8798713 [details] [diff] [review] Patch. (I can't recall what was the reason for the second postMessage. )
Attachment #8798713 -
Flags: review?(bugs) → review+
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 10•8 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #8) > Comment on attachment 8798713 [details] [diff] [review] > Patch. > > (I can't recall what was the reason for the second postMessage. ) http://searchfox.org/mozilla-central/source/browser/components/originattributes/test/browser/test_firstParty_postMessage.html will post a message to test.html, and test.html will reply a message back. I added setTimeout in case that somehow postMessage cannot work, so the setTimeout could send an error back to the document. However the timeout value seems caused some intermittent failure, so I simply remove it, and if one day the postMessage didn't work the test will still report error.
Status: NEW → ASSIGNED
Comment 11•8 years ago
|
||
Pushed by yhuang@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ab0d0603172e remove setTimeout to prevent intermittent failure. r=smaug
Comment 12•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ab0d0603172e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Updated•8 years ago
|
status-firefox50:
--- → unaffected
status-firefox51:
--- → affected
Whiteboard: [domsecurity-intermittent] [tor] → [domsecurity-intermittent][tor][checkin-needed-aurora]
Comment 13•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/4ebcaac67bec
Whiteboard: [domsecurity-intermittent][tor][checkin-needed-aurora] → [domsecurity-intermittent][tor]
Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•