Closed Bug 1300182 Opened 8 years ago Closed 8 years ago

Intermittent browser/components/originattributes/test/browser/browser_firstPartyIsolation.js | "KO" == "OK" -

Categories

(Core :: DOM: Security, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox50 --- unaffected
firefox51 --- fixed
firefox52 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: allstars.chh)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure, Whiteboard: [domsecurity-intermittent][tor])

Attachments

(1 file)

Blocks: 1260931
Component: General → DOM: Security
Flags: needinfo?(allstars.chh)
Product: Firefox → Core
Priority: -- → P3
Whiteboard: [domsecurity-intermittent]
Whiteboard: [domsecurity-intermittent] → [domsecurity-intermittent] [tor]
Assignee: nobody → allstars.chh
Flags: needinfo?(allstars.chh)
Attached patch Patch.Splinter Review
Hi smaug
I think the intermittent failure happens when the message received in the iframe side has some delay and makes it longer than 1000 mini-seconds, I simply removed the setTimeout to prevent this.

The try result seems good.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2edb8d82d435
Attachment #8798713 - Flags: review?(bugs)
Comment on attachment 8798713 [details] [diff] [review]
Patch.

(I can't recall what was the reason for the second postMessage. )
Attachment #8798713 - Flags: review?(bugs) → review+
(In reply to Olli Pettay [:smaug] from comment #8)
> Comment on attachment 8798713 [details] [diff] [review]
> Patch.
> 
> (I can't recall what was the reason for the second postMessage. )

http://searchfox.org/mozilla-central/source/browser/components/originattributes/test/browser/test_firstParty_postMessage.html
will post a message to test.html, and test.html will reply a message back.

I added setTimeout in case that somehow postMessage cannot work, so the setTimeout could send an error back to the document.
However the timeout value seems caused some intermittent failure, so I simply remove it, and if one day the postMessage didn't work the test will still report error.
Status: NEW → ASSIGNED
Pushed by yhuang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab0d0603172e
remove setTimeout to prevent intermittent failure. r=smaug
https://hg.mozilla.org/mozilla-central/rev/ab0d0603172e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Whiteboard: [domsecurity-intermittent] [tor] → [domsecurity-intermittent][tor][checkin-needed-aurora]
https://hg.mozilla.org/releases/mozilla-aurora/rev/4ebcaac67bec
Whiteboard: [domsecurity-intermittent][tor][checkin-needed-aurora] → [domsecurity-intermittent][tor]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: