1300214 - window.alert broken for tabs opened in RDM even after closing RDM

Status: VERIFIED FIXED

(DevTools :: Responsive Design Mode, defect, P1)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

STR:

1. data:text/html,<script>onclick=function(){alert('ok')}</script>
2. Click to trigger alert, works in a regular tab
3. Open in new RDM
4. Click to trigger alert, expected to fail there, this is bug 1273997
5. Close RDM
6. Click to trigger alert

ER:

It should start working again now that RDM is closed.

AR:

It continues to fail outside of RDM and remains broken for the life of that tab.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

This should now be fixed by bug 1301514.

Comment 2

[Mihai Boldan, Desktop QA [:mboldan]]

I managed to reproduce this issue on Firefox 50.0a1 (2016-07-27), under Windows 10 x64.
The issue is no longer reproducible on Firefox 51.0a1 (2016-09-14), under Windows 10x64, using STR from Comment 0.
On Mac OS X 10.11.1 and on Ubuntu 16.04 x64 the script from Comment 0 is not working, so I used the following script for testing this bug "javascript:onclick=function(){alert('ok')}".
Ryan, is this fix covered by this script on Ubuntu and Mac OS's?
Please let me know if there are any other tests that need to be performed around this issue.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Mihai Boldan, QA [:mboldan] from comment #2)
> I managed to reproduce this issue on Firefox 50.0a1 (2016-07-27), under
> Windows 10 x64.
> The issue is no longer reproducible on Firefox 51.0a1 (2016-09-14), under
> Windows 10x64, using STR from Comment 0.
> On Mac OS X 10.11.1 and on Ubuntu 16.04 x64 the script from Comment 0 is not
> working, so I used the following script for testing this bug
> "javascript:onclick=function(){alert('ok')}".
> Ryan, is this fix covered by this script on Ubuntu and Mac OS's?
> Please let me know if there are any other tests that need to be performed
> around this issue.

Hmm, I was able to test this issue by pasting the URL from comment 0 step 1 into a new tab's location bar on Mac and Ubuntu.  Is this what you did as well?  Maybe I was too vague by just including the URL...?

In any case, alerts are meant to be working for all OSes after exiting RDM with this change.

Comment 4

[Mihai Boldan, Desktop QA [:mboldan]]

It seems that the script is working on Mac OS X and Ubuntu OSs too. I'm not sure what I was doing wrong.
The issue was tested on Firefox 52.0a1 (2016-09-28), under Windows 10x64, Mac OS X 10.11.6 and under Ubuntu 16.04 x64.
I am marking this issue Verified Fixed since is not reproducible on the Latest Nightly.