Closed Bug 1300287 Opened 5 years ago Closed 5 years ago

stylo: move stylo shutdown hook to the same level as the init hook

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(1 file)

In bug 1291885 I temporarily moved the stylo init hook to nsAppRunner so that it would occur after the creation of the hidden DOM window (to support some short-lived hackery). I didn't move the shutdown hook, which causes an unbalanced shutdown call in xpcshell tests (which don't use nsAppRunner.cpp).

So I'm moving the shutdown hook too. This is NPOTB, and will all move back to nsLayoutStatics by the time we turn stylo on.
This mirrors the location of Servo_Init. This is important because xpcshell runs
don't use nsAppRunner, and so we end up with an unpaired call to Servo_Shutdown,
which crashes.
Attachment #8787850 - Flags: review+
Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1526a27947a5
Move Servo_Shutdown call to nsAppRunner.cpp. r=emilio
Blocks: stylo-incubator
No longer blocks: stylo
https://hg.mozilla.org/mozilla-central/rev/1526a27947a5
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.