1300338 - URL (from Google) causes hang on multiple machines and Windows 10 versions

Status: RESOLVED FIXED

(Core :: Graphics, defect, P3)

Description

[David Trapnell]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160823121617

Steps to reproduce:

Go to URL https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=7&cad=rja&uact=8&ved=0ahUKEwjeh8DgzPPOAhUHyWMKHWxXDTMQFghKMAY&url=http%3A%2F%2Faperiodical.com%2F2014%2F11%2Fan-alan-turing-expert-answers-your-the-imitation-game-questions%2F&usg=AFQjCNERgGT3co3w46B3V4SrhQMsCXZqhQ


Actual results:

The address bar transitions from the Google URL to the actual URL. The page seems to load. After a few seconds the little spinner in the tab freezes. After this, any attempt to interact with Firefox results in the "Not Responding" message in the title bar. It may still be closed by right-clicking the task bar and clicking "close", which has to be done twice, or via the Task Manager. The window will still minimize and restore while in this state. On the 8 core computer the Task manager shows Firefox at 12.5-14.4% constantly, indicating 100% for the task. The two computers initially showing the problem are Windows 10 build 10586. These computers evolved independently, they are not clones. I also recreated the problem on an "almost virgin" dual-core running Windows 10 Build 14393.rs1_release_inmarket.160819-1924 and the "latest" Firefox as of August 2016. The CPU on this machine for the task is at 51-54% indicating 100% for the task. I also recreated the problem on a quad-core laptop running 10586.


Expected results:

Going to the URL with IE 11 results in the page loading and scrolling normally. It also seems to open normally on Windows 7 Ultimate build 7601, although there is a slight hiccup at the point where it would otherwise hang. There also were normal results on a "well worn" Windows XP SP3 Build 2600.xpsp_sp3_qfe.130704-0421, a dual-core desktop running Windows 7 Pro 32 bit build 7601, a dual-core laptop running Windows 10 Home build 10240, a quad-core desktop running Windows 8 Pro Build 9200, and a dual-core desktop running Windows 8.0 Pro build 9200.

Comment 1

[Alice0775 White]

[Tracking Requested - why for this release]: Browser hangs

#1 With HWA, Firefox hangs.
#2 Without HWA, Fierfox does not hang. Blank page is shown, but there are invisible links.
   (I will file the other new bug for #2 problem.)


#1 Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=36c1e4eb0c9141aae4071a917ce4e3a59f5a79c6&tochange=d74084d072f0b5dfb00e3fbc103bef0a3fecbf85

#1 Regressed by: Bug 1220629

Comment 2

[Alice0775 White]

> #2 Without HWA, Fierfox does not hang. Blank page is shown, but there are invisible links.
   (I will file the other new bug for #2 problem.)
please ignore this. 

It seems no problem without HWA

Comment 3

[Gerry Chang [:gchang]]

Track for 49+/50+/51+ as this is a reproducible behavior and hang issue with HWA.

Comment 4

[timbugzilla]

Can reproduce on current nightly. Hangs browser straight away.

Comment 5

[Bas Schouten (:bas.schouten)]

In investigating this bug I've found an obvious performance optimization that as a side-effect fixes this bug. Patch upcoming.

Comment 6

[Bas Schouten (:bas.schouten)]

Attachment: Bug 1300338: Do not attempt to preserve layer content when we're going to override it in a blend operation anyway.

Review commit: https://reviewboard.mozilla.org/r/78216/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/78216/

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Regression from Firefox 46, too late to fix this in 49. We can still take a patch for 50 though.

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8790329 [details]
Bug 1300338: Do not attempt to preserve layer content when we're going to override it in a blend operation anyway.

https://reviewboard.mozilla.org/r/78216/#review77340

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1fef8a245875
Do not attempt to preserve layer content when we're going to override it in a blend operation anyway. r=jrmuizel

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out for Windows 8 reftest failures like https://treeherder.mozilla.org/logviewer.html#?job_id=3549715&repo=autoland

https://hg.mozilla.org/integration/autoland/rev/a001e3d12ce3

Comment 11

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Bulk move of gfx-noted bugs without priority to P3 for tracking.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/13fe99de32f6
Do not attempt to preserve layer content when we're going to override it in a blend operation anyway. r=jrmuizel

Comment 13

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/13fe99de32f6

Comment 14

[Gerry Chang [:gchang]]

Hi :bas,
Since this bug also affects 50/51, do you think the patch is worth uplifting to 50/51?

Comment 15

[Bas Schouten (:bas.schouten)]

(In reply to Gerry Chang [:gchang] from comment #14)
> Hi :bas,
> Since this bug also affects 50/51, do you think the patch is worth uplifting
> to 50/51?

50, yes, 51, it depends a little bit. The patch is not entirely risk free. It could potentially cause some graphics artifacts although so far it seems it doesn't.

Comment 16

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hello David, could you please verify this issue is fixed as expected on a latest Nightly build? Thanks!

Comment 17

[David Trapnell]

What is the "latest Nightly build" and where do I get it?
After many years in mainframe DP, this is my first exposure to open source.
Thanks for all the work. 
I immediately turned off hardware acceleration on all my computers as soon as I became aware of it.

Comment 18

[Kartikaya Gupta (email:[e-mail])]

It's the build of Firefox which contains the most recent changes (as of the previous night). You can download it from https://nightly.mozilla.org/

Comment 19

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Bas, based on comment 15, I assume you want this wontfix'd for 50. Or are you more comfortable uplifting now that this has been in Nightly for a few weeks?

Comment 20

[Gerry Chang [:gchang]]

Hi :milan,
Can you help create a uplift request for 51 aurora?

Comment 21

[Bas Schouten (:bas.schouten)]

Comment on attachment 8790329 [details]
Bug 1300338: Do not attempt to preserve layer content when we're going to override it in a blend operation anyway.

Approval Request Comment
[Feature/regressing bug #]: 1220629
[User impact if declined]: A website doing some very specific actions may take a very long time to complete (hang)
[Describe test coverage new/current, TreeHerder]: Extensive nightly testing
[Risks and why]: Somewhat, this could cause some artifacts with complex blending.
[String/UUID change made/needed]: None

Comment 22

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Given the risk associated with this uplift and the fact that we are entering RC mode on Monday, this is now a wontfix for 50.

Comment 23

[Gerry Chang [:gchang]]

Comment on attachment 8790329 [details]
Bug 1300338: Do not attempt to preserve layer content when we're going to override it in a blend operation anyway.

Fix a hang issue. Take it in 51 aurora.

Comment 24

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/79315c6e6d45

Comment 25

[David Trapnell]

This problem went away.