nsDOMEventsIIDs.cpp/.h should go

RESOLVED FIXED in mozilla0.9.5

Status

()

P3
normal
RESOLVED FIXED
19 years ago
2 years ago

People

(Reporter: mikepinkerton, Assigned: jag-mozilla)

Tracking

Trunk
mozilla0.9.5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

19 years ago
nsDOMEventIIDs.cpp/.h should go. All it does is waste static data space. All of
these iid's can be accessed through the GetIID methods.

Updated

19 years ago
Status: NEW → ASSIGNED

Comment 1

19 years ago
Actually, the preferred way is nsCOMTypeInfo<T>.GetIID(), called via the
NS_GET_IID(T) macro, I believe.  Hey scc, if this is right, should vidur or I go
ahead and whack the DOM code?  Vidur, you want dibs as you're in there now doing
exceptions?

(Pink gives me bugs all the time, I think he likes me!)

/be
(Reporter)

Comment 2

19 years ago
naw, it's not that i like you, i just know you're good at rote global search and
replace ;) ;)

Comment 3

19 years ago
Yes, use |NS_GET_IID(T)|.  It is short for |nsCOMTypeInfo<T>::GetIID()|.

Comment 4

19 years ago
http://lxr.mozilla.org/mozilla/find?string=IIDs finds stuff, I'll fix it all.

/be

Comment 5

19 years ago
No DOM code needs to be whacked from what I can see - the IIDs in layout were
defined by joki, I think. Taking myself off of this one.

Updated

19 years ago
Target Milestone: M11

Comment 6

19 years ago
I'll look at this soon.

/be

Updated

19 years ago
Target Milestone: M11 → M14

Updated

19 years ago
Target Milestone: M14 → M15
I lied, I'll look at this later.  Or let scc take it, if he's on a mission from
god to clean up all such wastes.

/be
Argh, not gonna happen by tomorrow -- pushing to M16.

/be
Target Milestone: M15 → M16
Moving out.

/be
Target Milestone: M16 → M18
Moving out, milestone 20 will become a better Mozilla milestone soon.

/be
Target Milestone: M18 → M20

Updated

18 years ago
Target Milestone: M20 → mozilla0.9

Updated

18 years ago
Keywords: mozilla1.0

Comment 11

18 years ago
dp is no longer @netscape.com. changing qa contact to default for this product
QA Contact: dp → kandrot
Slipping.
Target Milestone: mozilla0.9 → mozilla0.9.1
Load-balancing.

/be
Target Milestone: mozilla0.9.1 → mozilla0.9.2

Updated

17 years ago
Target Milestone: mozilla0.9.2 → mozilla0.9.3
Does anyone care?  Or should I WONTFIX this?

/be
Summary: nsDOMEventIIDs.cpp/.h should go → nsDOMEventsIIDs.cpp/.h should go
Target Milestone: mozilla0.9.3 → mozilla0.9.5

Comment 15

17 years ago
Yeah, let's get rid of it. cc'ing jag & jst. 
Created attachment 43834 [details] [diff] [review]
No more nsDOMEventsIIDs.* and no more dlldeps.cpp
The attached patch gets rid of the nsDOMEventsIIDs.* files and at the same time
makes us not compile dlldeps.cpp (since it's not needed any more), this still
needs some mac build system help before checking in.
waterson told me too -- plus, I know jag wants it!

(THANKS!)

/be
Assignee: brendan → jaggernaut
Status: ASSIGNED → NEW
(Assignee)

Comment 19

17 years ago
Wheeeeeeeeeeeeee!

r=jag.

Thanks jst :-)

So who's gonna be the proud sr= giver?
sr=brendan@mozilla.org if you keep the Mac happy, too.

/be
(Assignee)

Comment 21

17 years ago
Checked in, marking fixed.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.