13004 - nsDOMEventsIIDs.cpp/.h should go

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Mike Pinkerton (not reading bugmail)]

nsDOMEventIIDs.cpp/.h should go. All it does is waste static data space. All of
these iid's can be accessed through the GetIID methods.

Comment 1

[brendan-obsolete]

Actually, the preferred way is nsCOMTypeInfo<T>.GetIID(), called via the
NS_GET_IID(T) macro, I believe.  Hey scc, if this is right, should vidur or I go
ahead and whack the DOM code?  Vidur, you want dibs as you're in there now doing
exceptions?

(Pink gives me bugs all the time, I think he likes me!)

/be

Comment 2

[Mike Pinkerton (not reading bugmail)]

naw, it's not that i like you, i just know you're good at rote global search and
replace ;) ;)

Comment 3

[Scott Collins]

Yes, use |NS_GET_IID(T)|.  It is short for |nsCOMTypeInfo<T>::GetIID()|.

Comment 4

[brendan-obsolete]

http://lxr.mozilla.org/mozilla/find?string=IIDs finds stuff, I'll fix it all.

/be

Comment 5

[vidur (gone)]

No DOM code needs to be whacked from what I can see - the IIDs in layout were
defined by joki, I think. Taking myself off of this one.

Comment 6

[brendan-obsolete]

I'll look at this soon.

/be

Comment 7

[Brendan Eich [:brendan]]

I lied, I'll look at this later.  Or let scc take it, if he's on a mission from
god to clean up all such wastes.

/be

Comment 8

[Brendan Eich [:brendan]]

Argh, not gonna happen by tomorrow -- pushing to M16.

/be

Comment 9

[Brendan Eich [:brendan]]

Moving out.

/be

Comment 10

[Brendan Eich [:brendan]]

Moving out, milestone 20 will become a better Mozilla milestone soon.

/be

Comment 11

[Dawn Endico]

dp is no longer @netscape.com. changing qa contact to default for this product

Comment 12

[Brendan Eich [:brendan]]

Slipping.

Comment 13

[Brendan Eich [:brendan]]

Load-balancing.

/be

Comment 14

[Brendan Eich [:brendan]]

Does anyone care?  Or should I WONTFIX this?

/be

Comment 15

[Chris Waterson]

Yeah, let's get rid of it. cc'ing jag & jst. 

Comment 16

[Johnny Stenback (:jst)]

Attachment: No more nsDOMEventsIIDs.* and no more dlldeps.cpp

Comment 17

[Johnny Stenback (:jst)]

The attached patch gets rid of the nsDOMEventsIIDs.* files and at the same time
makes us not compile dlldeps.cpp (since it's not needed any more), this still
needs some mac build system help before checking in.

Comment 18

[Brendan Eich [:brendan]]

waterson told me too -- plus, I know jag wants it!

(THANKS!)

/be

Comment 19

[jag (Peter Annema)]

Wheeeeeeeeeeeeee!

r=jag.

Thanks jst :-)

So who's gonna be the proud sr= giver?

Comment 20

[Brendan Eich [:brendan]]

sr=[e-mail] if you keep the Mac happy, too.

/be

Comment 21

[jag (Peter Annema)]

Checked in, marking fixed.