1300442 - Update string formatting, log further information, house keeping

Status: RESOLVED FIXED

(Testing Graveyard :: external-media-tests, defect)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Bug to track a number of QoL changes to the tests:
- There is a mix of old style formatting ('%') and new (.format()) in the tests. Should update all of these to the new style.
- Some new style formatters use positional arguments, i.e. '{0}'.format('foo'), this is not required in python 2.7 or 3+ unless switching the order of arguments, so can use non positionals.
- There are some long lines that can be cleaned up to comply with pep8.
- Line continuation can use parens rather than slashes for consistency.
- Log the interval being used in the VideoPuppeteer to improve information for failure cases.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1300442 - Housekeeping and QoL changes: code style, extra logging on VP.

- Use format() instead of old style formatting (%s, etc).
- Remove unneeded positional args on format strings.
- Break some long lines for pep8 conformance.
- Use brackets instead of \ to continue long lines.
- Log interval on video puppeteer.

Review commit: https://reviewboard.mozilla.org/r/76536/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76536/

Comment 2

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 8788010 [details]
Bug 1300442 - Housekeeping and QoL changes: code style, extra logging on VP.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/76536/diff/1-2/

Comment 3

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

You could also include external-media-tests in the lint job on Treeherder: see https://groups.google.com/forum/#!topic/mozilla.release.engineering/2qh1lvTlE9U

Comment 4

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8788010 [details]
Bug 1300442 - Housekeeping and QoL changes: code style, extra logging on VP.

https://reviewboard.mozilla.org/r/76536/#review75120

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60856a997b32
Housekeeping and QoL changes: code style, extra logging on VP. r=maja_zf

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/60856a997b32

Comment 7

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Follow up to track flake8 linting: Bug 1302592