If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Update string formatting, log further information, house keeping

RESOLVED FIXED in Firefox 51

Status

Testing
external-media-tests
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: SingingTree, Assigned: SingingTree)

Tracking

Trunk
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Bug to track a number of QoL changes to the tests:
- There is a mix of old style formatting ('%') and new (.format()) in the tests. Should update all of these to the new style.
- Some new style formatters use positional arguments, i.e. '{0}'.format('foo'), this is not required in python 2.7 or 3+ unless switching the order of arguments, so can use non positionals.
- There are some long lines that can be cleaned up to comply with pep8.
- Line continuation can use parens rather than slashes for consistency.
- Log the interval being used in the VideoPuppeteer to improve information for failure cases.
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Assignee: nobody → bvandyk
Comment hidden (mozreview-request)
You could also include external-media-tests in the lint job on Treeherder: see https://groups.google.com/forum/#!topic/mozilla.release.engineering/2qh1lvTlE9U

Comment 4

a year ago
mozreview-review
Comment on attachment 8788010 [details]
Bug 1300442 - Housekeeping and QoL changes: code style, extra logging on VP.

https://reviewboard.mozilla.org/r/76536/#review75120
Attachment #8788010 - Flags: review?(mjzffr) → review+

Comment 5

a year ago
Pushed by bvandyk@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/60856a997b32
Housekeeping and QoL changes: code style, extra logging on VP. r=maja_zf

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/60856a997b32
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
(Assignee)

Comment 7

a year ago
Follow up to track flake8 linting: Bug 1302592
You need to log in before you can comment on or make changes to this bug.