Closed Bug 1300442 Opened 3 years ago Closed 3 years ago

Update string formatting, log further information, house keeping

Categories

(Testing Graveyard :: external-media-tests, defect)

defect
Not set

Tracking

(firefox51 fixed)

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: bryce, Assigned: bryce)

Details

Attachments

(1 file)

Bug to track a number of QoL changes to the tests:
- There is a mix of old style formatting ('%') and new (.format()) in the tests. Should update all of these to the new style.
- Some new style formatters use positional arguments, i.e. '{0}'.format('foo'), this is not required in python 2.7 or 3+ unless switching the order of arguments, so can use non positionals.
- There are some long lines that can be cleaned up to comply with pep8.
- Line continuation can use parens rather than slashes for consistency.
- Log the interval being used in the VideoPuppeteer to improve information for failure cases.
Assignee: nobody → bvandyk
You could also include external-media-tests in the lint job on Treeherder: see https://groups.google.com/forum/#!topic/mozilla.release.engineering/2qh1lvTlE9U
Comment on attachment 8788010 [details]
Bug 1300442 - Housekeeping and QoL changes: code style, extra logging on VP.

https://reviewboard.mozilla.org/r/76536/#review75120
Attachment #8788010 - Flags: review?(mjzffr) → review+
Pushed by bvandyk@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/60856a997b32
Housekeeping and QoL changes: code style, extra logging on VP. r=maja_zf
https://hg.mozilla.org/mozilla-central/rev/60856a997b32
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Follow up to track flake8 linting: Bug 1302592
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.