1300529 - HTMLMediaElement::CaptureStreamInternal called incorrectly

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect, P1)

Description

[Andreas Pehrson [:pehrsons]]

Farmer Tseng pointed out that I had changed the signature of CaptureStreamInternal to include a bool for whether or not audio should be captured from the media element, but I had forgotten to update the callsites.

The compiler doesn't complain about this apparently - the third (and optional) `MediaStreamGraph*` argument was implicitly cast to the new bool as second argument. Leaving the bool always true and the MediaStreamGraph* always to default (nullptr).

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1300529 - Remove default arguments from HTMLMediaElement::CaptureStreamInternal.

Review commit: https://reviewboard.mozilla.org/r/76764/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76764/

Comment 2

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1300529 - Remove default arguments from AudioNodeStream::Create.

Review commit: https://reviewboard.mozilla.org/r/76766/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76766/

Comment 3

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8788196 [details]
Bug 1300529 - Remove default arguments from HTMLMediaElement::CaptureStreamInternal.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/76764/diff/1-2/

Comment 4

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8788197 [details]
Bug 1300529 - Remove default arguments from AudioNodeStream::Create.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/76766/diff/1-2/

Comment 5

[Paul Adenot (:padenot)]

Comment on attachment 8788197 [details]
Bug 1300529 - Remove default arguments from AudioNodeStream::Create.

https://reviewboard.mozilla.org/r/76766/#review75424

::: dom/media/webaudio/AudioNodeStream.h:65
(Diff revision 2)
>      EXTERNAL_OUTPUT = 1U << 2,
>    };
>    /**
>     * Create a stream that will process audio for an AudioNode.
>     * Takes ownership of aEngine.
>     * If aGraph is non-null, use that as the MediaStreamGraph, otherwise use

Passing in nullptr is now illegal (and a bunch of assert make sure of this), update this comment.

Comment 6

[Paul Adenot (:padenot)]

Comment on attachment 8788196 [details]
Bug 1300529 - Remove default arguments from HTMLMediaElement::CaptureStreamInternal.

https://reviewboard.mozilla.org/r/76764/#review75428

::: dom/html/HTMLMediaElement.cpp:2653
(Diff revision 2)
>  
>  already_AddRefed<DOMMediaStream>
>  HTMLMediaElement::CaptureAudio(ErrorResult& aRv,
>                                 MediaStreamGraph* aGraph)
>  {
> -  RefPtr<DOMMediaStream> stream = CaptureStreamInternal(false, aGraph);
> +  RefPtr<DOMMediaStream> stream =

MOZ_RELEASE_ASSERT(aGraph);

Comment 7

[Paul Adenot (:padenot)]

Comment on attachment 8788196 [details]
Bug 1300529 - Remove default arguments from HTMLMediaElement::CaptureStreamInternal.

https://reviewboard.mozilla.org/r/76764/#review75430

Comment 8

[Paul Adenot (:padenot)]

Comment on attachment 8788196 [details]
Bug 1300529 - Remove default arguments from HTMLMediaElement::CaptureStreamInternal.

https://reviewboard.mozilla.org/r/76764/#review75442

Comment 9

[Paul Adenot (:padenot)]

Comment on attachment 8788196 [details]
Bug 1300529 - Remove default arguments from HTMLMediaElement::CaptureStreamInternal.

https://reviewboard.mozilla.org/r/76764/#review75444

Comment 10

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8788196 [details]
Bug 1300529 - Remove default arguments from HTMLMediaElement::CaptureStreamInternal.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/76764/diff/2-3/

Comment 11

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8788197 [details]
Bug 1300529 - Remove default arguments from AudioNodeStream::Create.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/76766/diff/2-3/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c71a80c9b8e9
Remove default arguments from HTMLMediaElement::CaptureStreamInternal. r=padenot
https://hg.mozilla.org/integration/autoland/rev/904d4282def8
Remove default arguments from AudioNodeStream::Create. r=padenot

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c71a80c9b8e9
https://hg.mozilla.org/mozilla-central/rev/904d4282def8