Closed Bug 1300569 Opened 3 years ago Closed 3 years ago

Use palette support library instead of BitmapUtils.getDominantColor()

Categories

(Firefox for Android :: Favicon Handling, defect, P1)

Product:
Firefox for Android
Component:
Favicon Handling
Platform:
All
Android
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 51
Iteration:
1.4
Tracking Flags:
Tracking Status
firefox51 --- fixed

People

(Reporter: sebastian, Assigned: sebastian)

References

Details

(Whiteboard: [MobileAS])

Attachments

(1 file)

Bug 1300569 - Add palette-v7 support library to build.
58 bytes, text/x-review-board-request
ahunt
: review+
Details 
The palette library seems to return similar values like BitmapUtils.getDominantColor(). It's much faster though (10-20ms / bitmap).
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [MobileAS]
Some results from browsing:
* 64x64 - 25ms vs. 9ms
* 64x64 - 11ms vs. 3ms
* 64x64 - 22ms vs. 2ms
* 64x64 - 7ms vs. 2ms
* 64x64 - 13ms vs. 2ms
* 64x64 - 27ms vs. 3ms
* 64x64 - 17ms vs. 5ms
* 64x64 - 15ms vs. 2ms
* 64x64 - 21ms vs. 3ms
* 64x64 - 14ms vs. 2ms
* 64x64 - 18ms vs. 2ms
The patch to actually use the library is attached to bug 1300543.
Comment on attachment 8788337 [details]
Bug 1300569 - Add palette-v7 support library to build.

https://reviewboard.mozilla.org/r/76864/#review75104
Attachment #8788337 - Flags: review?(ahunt) → review+
Pushed by s.kaspari@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3a87bca22135
Add palette-v7 support library to build. r=ahunt
https://hg.mozilla.org/mozilla-central/rev/3a87bca22135
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Iteration: --- → 1.4
You need to log in before you can comment on or make changes to this bug.