Closed Bug 1300726 Opened 8 years ago Closed 8 years ago

[WMF] Replace IMFSample::GetBufferByIndex() with IMFSample::ConvertToContiguousBuffer().

Categories

(Core :: Audio/Video: Playback, defect, P3)

Product:
Core
Component:
Audio/Video: Playback
Version:
Other Branch
Type:
defect

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: alwu, Assigned: alwu)

Details

According to Microsoft's suggestion [1], it's safer to use IMFSample::ConvertToContiguousBuffer() instead of IMFSample::GetBufferByIndex() [2]. [1] https://msdn.microsoft.com/zh-tw/library/windows/desktop/ms697014(v=vs.85).aspx [2] http://searchfox.org/mozilla-central/source/dom/media/platforms/wmf/DXVA2Manager.cpp#444
Because I'm just starting to study the WMF, please feel free to correct me if this changing is no needed.
I don't think we need (or want) to make this change. The buffers here are D3D9 surfaces, I don't see how we could ever have multiple buffers, or how ConvertToContiguousBuffer could combine them.
According to the comment2, it seems we don't need to make this change.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.