1300757 - [Static Analysis][ Structurally dead code] In function CanvasRenderingContext2D::TrySkiaGLTarget

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity detected that the following portion of the code will not be executed:

>>  if (!aOutDT) {
>>    return false;  	
>>    gfxCriticalNote << "Failed to create a SkiaGL DrawTarget, falling back to software\n";
>>  }

This part of the code has been added by a major refactoring in Bug 1298345.

Comment 1

[Andi [:andi]]

Attachment: Bug 1300757 - log error message if SkiaGL DrawTarget fails.

Review commit: https://reviewboard.mozilla.org/r/76940/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76940/

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8788430 [details]
Bug 1300757 - log error message if SkiaGL DrawTarget fails.

https://reviewboard.mozilla.org/r/76940/#review75056

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eff773a2ba3e
log error message if SkiaGL DrawTarget fails. r=baku

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/eff773a2ba3e