Closed Bug 1300757 Opened 3 years ago Closed 3 years ago

[Static Analysis][ Structurally dead code] In function CanvasRenderingContext2D::TrySkiaGLTarget

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 1372475)

Attachments

(1 file)

The Static Analysis tool Coverity detected that the following portion of the code will not be executed:

>>  if (!aOutDT) {
>>    return false;  	
>>    gfxCriticalNote << "Failed to create a SkiaGL DrawTarget, falling back to software\n";
>>  }

This part of the code has been added by a major refactoring in Bug 1298345.
Comment on attachment 8788430 [details]
Bug 1300757 - log error message if SkiaGL DrawTarget fails.

https://reviewboard.mozilla.org/r/76940/#review75056
Attachment #8788430 - Flags: review?(amarchesini) → review+
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eff773a2ba3e
log error message if SkiaGL DrawTarget fails. r=baku
https://hg.mozilla.org/mozilla-central/rev/eff773a2ba3e
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.