1300779 - [mozlint] Re-direct stderr when checking for vcs root

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[Andrew Halberstadt [:ahal]]

We run either 'hg root' or 'git rev-parse' to determine the root of the repository. However we don't redirect stderr, so git users see a confusing 'abort: .hg not found!' error every time.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1300779 - [mozlint] Redirect stderr when detecting version control root,

This avoids printing harmless (but confusing) errors to the log. For instance, git users
will see a '.hg not found!' error in the output even though not finding an hg repo is
expected in that case.

Review commit: https://reviewboard.mozilla.org/r/76976/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76976/

Comment 2

[Steven MacLeod [:smacleod]]

Comment on attachment 8788473 [details]
Bug 1300779 - [mozlint] Redirect stderr when detecting version control root,

https://reviewboard.mozilla.org/r/76976/#review75254

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68d9ee399317
[mozlint] Redirect stderr when detecting version control root, r=smacleod

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/68d9ee399317