[mozlint] Re-direct stderr when checking for vcs root

RESOLVED FIXED in Firefox 51

Status

defect
RESOLVED FIXED
3 years ago
5 months ago

People

(Reporter: ahal, Assigned: ahal)

Tracking

3 Branch
mozilla51

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
We run either 'hg root' or 'git rev-parse' to determine the root of the repository. However we don't redirect stderr, so git users see a confusing 'abort: .hg not found!' error every time.
Comment hidden (mozreview-request)

Comment 2

3 years ago
mozreview-review
Comment on attachment 8788473 [details]
Bug 1300779 - [mozlint] Redirect stderr when detecting version control root,

https://reviewboard.mozilla.org/r/76976/#review75254
Attachment #8788473 - Flags: review?(smacleod) → review+

Comment 3

3 years ago
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/68d9ee399317
[mozlint] Redirect stderr when detecting version control root, r=smacleod

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/68d9ee399317
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51

Updated

a year ago
Product: Testing → Firefox Build System
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.