1300805 - Disable WebVTT breaks some controls of the native media player

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect)

Description

[António Novo]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20160904030201

Steps to reproduce:

Create/use a new/clean profile;
Disable WebVTT by setting media.webvtt.enabled to false;
Play any media (even audio only tracks present the issue) using the browser embed media player, example:
http://techslides.com/demos/sample-videos/small.webm


Actual results:

Notice the lack of properties and feedback about the playback on the embed media player.
Some controls work, like setting the volume, but there is no feedback in the interface about the changes made, not even the playing progress is tracked.


Expected results:

Embed player UI should correctly display the playback properties when WebVTT is disabled.

Comment 1

[Loic]

Reg range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c9edfe35619f69f7785776ebd19a3140684024dc&tochange=437fc937572dd344f58226d40ba9eccb4ffcaedb

Ray Lin — Bug 887934 - Add closed caption button to video control. r=jaws

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Ray, can you include a test that uses the closed captioning menu as part of this patch?

Comment 3

[Ray Lin[:ralin]]

okay, no problem.

It's a good starting point for me to write test. Thank you Jared.

Comment 4

[Marcia Knous [:marcia]]

Tracking 51+ for this regression.

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Note Firefox 50 enters beta soon...

Comment 6

[Justin Dolske [:Dolske]]

Can I ask a dumb question? Is there a reason to keep support for the media.webvtt.enabled pref?

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

None that I know of. This bug looked like a good way to add tests here.

Ralph, is this pref worth keeping around?

Comment 8

[Ralph Giles (:rillian)]

It is not. Let's remove it.

Comment 9

[Ralph Giles (:rillian)]

Attachment: Bug 1300805 - Remove media.webvtt.enabled pref.

This API has been deployed to release for some time. There isi
no longer value to being able to quickly disable it.

Review commit: https://reviewboard.mozilla.org/r/79078/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79078/

Comment 10

[Matthew Gregan [:kinetik]]

Comment on attachment 8791802 [details]
Bug 1300805 - Remove media.webvtt.enabled pref.

https://reviewboard.mozilla.org/r/79078/#review77706

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Sorry about the relay in response -- Taipei is on holiday from Sep 15-16.

Comment 12

[Ralph Giles (:rillian)]

No worries. This is just waiting on dom peer review.

Comment 13

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8791802 [details]
Bug 1300805 - Remove media.webvtt.enabled pref.

https://reviewboard.mozilla.org/r/79078/#review77858

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf19bbf00b0e
Remove media.webvtt.enabled pref. r=kinetik,smaug

Comment 15

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/cf19bbf00b0e

Comment 16

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Ralph, should we uplift this fix to Beta50?

Comment 17

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked since it's a recent regression in Fx50.

Comment 18

[Ralph Giles (:rillian)]

Hmm, it's early in the cycle, so sure. Triggering the regression requires setting a non-default pref though, so it's not a big deal either way.

Comment 19

[Ralph Giles (:rillian)]

Attachment: Backport to beta 50

Approval Request Comment
[Feature/regressing bug #]: 1300805
[User impact if declined]: (Regression) Unresponsive media playback controls for users who set a non-default pref.
[Describe test coverage new/current, TreeHerder]: Landed on m-c before it went to aurora. No changes in default behaviour.
[Risks and why]: Risk is some side effect of removing the pref will affect other behaviour. However, the pref has been on by default for many releases, so I think this is not important. It may be surprising to remove the pref in beta at the same time as dev edition, but I think avoiding broken controls is more important.
[String/UUID change made/needed]: None

Comment 20

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hello Antonio, could you please verify this issue is fixed as expected on a latest Nightly build? Thanks!

Comment 21

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8794399 [details] [diff] [review]
Backport to beta 50

Removing a perf that has been on by default for a few releases and as such the pref is not needed anymore, Beta50+

Comment 22

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/releases/mozilla-beta/rev/48d77c582ec4

Comment 23

[Bogdan Maris, Desktop QA]

Reproduced the initial behavior using old Nightly from 2016-09-06, verified that using latest builds, Firefox 50 beta 2, latest Developer Edition 51.0a2 and latest Nightly 52.0a1 across platforms (Mac OS X 10.10.5, Windows 10 64-bit and Ubuntu 16.04 32-bit) the issue is no longer reproducible due to the removal of pref "media.webvtt.enabled"