1300827 - The find-in-page selections that are not the currently selected match don't look like the selected match (have no border-radius)

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: find-bug.png

See attached screenshot.

It looks odd that the white selection doesn't match the yellow selection. We should give the white selection rounded borders.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Hey Sevaan, Mike implemented this according to the spec but it feels awkward to me.

What do you think about putting the same border-radius on the white selections?

Comment 2

[Sevaan Franks [:sevaan]]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #1)
> What do you think about putting the same border-radius on the white
> selections?

I think let's do it!

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1300827 - The find-in-page selections that are not selected should have the same border-radius that the selected item has.

Review commit: https://reviewboard.mozilla.org/r/77276/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77276/

Comment 4

[Mike de Boer [:mikedeboer]]

Comment on attachment 8788974 [details]
Bug 1300827 - The find-in-page selections that are not selected should have the same border-radius that the selected item has.

https://reviewboard.mozilla.org/r/77276/#review75538

LGTM! Thanks.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/3756b6695c10
The find-in-page selections that are not selected should have the same border-radius that the selected item has. r=mikedeboer

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3756b6695c10