Closed Bug 1300827 Opened 3 years ago Closed 3 years ago

The find-in-page selections that are not the currently selected match don't look like the selected match (have no border-radius)

Categories

(Toolkit :: Find Toolbar, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(2 files)

Attached image find-bug.png
See attached screenshot.

It looks odd that the white selection doesn't match the yellow selection. We should give the white selection rounded borders.
Hey Sevaan, Mike implemented this according to the spec but it feels awkward to me.

What do you think about putting the same border-radius on the white selections?
Flags: needinfo?(sfranks)
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #1)
> What do you think about putting the same border-radius on the white
> selections?

I think let's do it!
Flags: needinfo?(sfranks)
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Comment on attachment 8788974 [details]
Bug 1300827 - The find-in-page selections that are not selected should have the same border-radius that the selected item has.

https://reviewboard.mozilla.org/r/77276/#review75538

LGTM! Thanks.
Attachment #8788974 - Flags: review?(mdeboer) → review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/3756b6695c10
The find-in-page selections that are not selected should have the same border-radius that the selected item has. r=mikedeboer
https://hg.mozilla.org/mozilla-central/rev/3756b6695c10
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.