1300844 - Remove Action* and Context* and use QuotaClient helpers introduced in bug 1217544

Status: NEW

(Core :: DOM: Service Workers, defect, P3)

Description

[Fernando Jiménez Moreno [:ferjm]]

https://bugzilla.mozilla.org/show_bug.cgi?id=1217544#c89

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8832161 [details] [diff] [review]
v1

This patch removes dom/cache/Action* and dom/cache/Context* in favor of the QuotaClient helpers introduced in bug 1217544.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8832161 [details] [diff] [review]
v1

Review of attachment 8832161 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this!  Just a couple questions before we move forward, though:

Can you clarify the situation with CacheId?  It seems the ClientContext uses its own concept of a storage ID, but we still define a CacheId type separately?  That seems like it needs to get unified somehow.

This needs to delete Context.cpp.  Its removed from the moz.build, but the file itself is not removed AFAICT.

::: dom/cache/Types.h
@@ +24,5 @@
>  };
>  static const Namespace INVALID_NAMESPACE = NUMBER_OF_NAMESPACES;
>  
>  typedef int64_t CacheId;
>  static const CacheId INVALID_CACHE_ID = -1;

Should these be removed in favor of the quota primitives now?  I noticed you replaced many uses of CacheId with int64_t directly.

Comment 5

[Jamie Hoefling]

Attachment: same problem

Thanks from beschdobamca1978.