Share Ctrl+Tab panel styling across platforms

RESOLVED FIXED in Firefox 51

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
Ctrl+Tab panel styling is almost identical across platforms, so we should share it instead of duplicating it.
Assignee

Comment 1

3 years ago
Posted patch patchSplinter Review
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Attachment #8788827 - Flags: review?(gijskruitbosch+bugs)

Comment 2

3 years ago
Comment on attachment 8788827 [details] [diff] [review]
patch

Review of attachment 8788827 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/ctrlTab.inc.css
@@ +11,5 @@
>    background: hsla(0,0%,33%,.85);
>    color: white;
>    border-style: none;
>    padding: 20px 10px 10px;
> +  text-shadow: 0 0 1px hsl(0,0%,12%), 0 0 2px hsl(0,0%,12%);

Nitty nit: Leave the text-shadow beneath the endif to avoid the line "changing" (but not really) in blame/annotate?
Attachment #8788827 - Flags: review?(gijskruitbosch+bugs) → review+
Assignee

Updated

3 years ago
Summary: Share Ctrl+Tab panel theme code across platforms → Share Ctrl+Tab panel styling across platforms

Comment 3

3 years ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac6340bb3152
Share Ctrl+Tab panel styling across platforms. r=gijs

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ac6340bb3152
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
You need to log in before you can comment on or make changes to this bug.