Closed
Bug 1300876
Opened 9 years ago
Closed 9 years ago
Share Ctrl+Tab panel styling across platforms
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
Details
Attachments
(1 file)
|
88.14 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
Ctrl+Tab panel styling is almost identical across platforms, so we should share it instead of duplicating it.
|
Assignee | |
Comment 1•9 years ago
|
||
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Attachment #8788827 -
Flags: review?(gijskruitbosch+bugs)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8788827 [details] [diff] [review]
patch
Review of attachment 8788827 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/themes/shared/ctrlTab.inc.css
@@ +11,5 @@
> background: hsla(0,0%,33%,.85);
> color: white;
> border-style: none;
> padding: 20px 10px 10px;
> + text-shadow: 0 0 1px hsl(0,0%,12%), 0 0 2px hsl(0,0%,12%);
Nitty nit: Leave the text-shadow beneath the endif to avoid the line "changing" (but not really) in blame/annotate?
Attachment #8788827 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
Assignee | |
Updated•9 years ago
|
Summary: Share Ctrl+Tab panel theme code across platforms → Share Ctrl+Tab panel styling across platforms
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac6340bb3152
Share Ctrl+Tab panel styling across platforms. r=gijs
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
You need to log in
before you can comment on or make changes to this bug.
Description
•