1300932 - ES3 should enable GLFeature::draw_buffers

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

In bug 1056947, we made ES3 not enable draw_buffers, because ES3 doesn't allow draw_buffers usage in ES1 shaders. (Thus WebGL1 on ES3 would fail to compile shaders that use #extension draw_buffers)

However, this also causes fDrawBuffers to not be loaded in GLContext. fDrawBuffers is core in WebGL2, so we need to repair this logic.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1300932 - Enable draw_buffers on ES3, but not WEBGL_draw_buffers. -

Review commit: https://reviewboard.mozilla.org/r/77100/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77100/

Comment 2

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Comment on attachment 8788704 [details]
Bug 1300932 - Enable draw_buffers on ES3, but not WEBGL_draw_buffers. -

https://reviewboard.mozilla.org/r/77100/#review75364

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8302d9c4a62b
Enable draw_buffers on ES3, but not WEBGL_draw_buffers. - r=jerry

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8302d9c4a62b