Closed
Bug 1300963
Opened 10 years ago
Closed 10 years ago
Baldr: remove "default" import special case
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: luke, Assigned: luke)
References
Details
Attachments
(2 files)
|
23.44 KB,
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
|
7.87 KB,
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
As changed in JS.md a while ago:
https://github.com/WebAssembly/design/pull/728
Attachment #8788745 -
Flags: review?(bbouvier)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8788745 [details] [diff] [review]
fix-import-empty-str
Review of attachment 8788745 [details] [diff] [review]:
-----------------------------------------------------------------
Nice
Attachment #8788745 -
Flags: review?(bbouvier) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
Unrelated, but noticed some dead code (now that we require signal handlers).
Attachment #8788908 -
Flags: review?(bbouvier)
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8788908 [details] [diff] [review]
rm-asmjs-interrupt
Review of attachment 8788908 [details] [diff] [review]:
-----------------------------------------------------------------
\o/
Attachment #8788908 -
Flags: review?(bbouvier) → review+
Pushed by lwagner@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0954858f2c96
Baldr: remove default import special case (r=bbouvier)
https://hg.mozilla.org/integration/mozilla-inbound/rev/5db21f7f4efa
Baldr: remove dead AsmJSInterrupt Ion nodes (r=bbouvier)
|
||
Comment 5•10 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0954858f2c96
https://hg.mozilla.org/mozilla-central/rev/5db21f7f4efa
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•