Closed Bug 1301008 Opened 3 years ago Closed 3 years ago

v4 list states cannot be correctly sent if it includes '\0'

Categories

(Toolkit :: Safe Browsing, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: hchang, Assigned: hchang)

Details

(Whiteboard: #sbv4-m1)

Attachments

(1 file)

From the API perspective [1], states containing '\0' wouldn't be passed in completely. This leads to incomplete state being sent to the server.

[1] https://dxr.mozilla.org/mozilla-central/rev/4ee5ddeeee281b9b6f564fc56efb1713da8d7eac/toolkit/components/url-classifier/nsUrlClassifierUtils.cpp#270
Assignee: nobody → hchang
Whiteboard: #sbv4-m1
Attachment #8788820 - Flags: review?(francois)
Comment on attachment 8788820 [details]
Bug 1301008 - Pass safebrowsing v4 list state in base64 format to avoid truncation.

https://reviewboard.mozilla.org/r/77170/#review75600
Attachment #8788820 - Flags: review?(francois) → review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/92f041a22d0a
Pass safebrowsing v4 list state in base64 format to avoid truncation. r=francois
https://hg.mozilla.org/mozilla-central/rev/92f041a22d0a
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.