v4 list states cannot be correctly sent if it includes '\0'

RESOLVED FIXED in Firefox 51

Status

()

Toolkit
Safe Browsing
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: hchang, Assigned: hchang)

Tracking

unspecified
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

(Whiteboard: #sbv4-m1)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
From the API perspective [1], states containing '\0' wouldn't be passed in completely. This leads to incomplete state being sent to the server.

[1] https://dxr.mozilla.org/mozilla-central/rev/4ee5ddeeee281b9b6f564fc56efb1713da8d7eac/toolkit/components/url-classifier/nsUrlClassifierUtils.cpp#270
(Assignee)

Updated

a year ago
Assignee: nobody → hchang
(Assignee)

Updated

a year ago
Whiteboard: #sbv4-m1
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8788820 - Flags: review?(francois)

Comment 2

a year ago
mozreview-review
Comment on attachment 8788820 [details]
Bug 1301008 - Pass safebrowsing v4 list state in base64 format to avoid truncation.

https://reviewboard.mozilla.org/r/77170/#review75600
Attachment #8788820 - Flags: review?(francois) → review+

Comment 3

a year ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/92f041a22d0a
Pass safebrowsing v4 list state in base64 format to avoid truncation. r=francois

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/92f041a22d0a
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.