1301186 - Email invitation may not be displayed when description contains non ascii characters

Status: RESOLVED FIXED

Description

[kkapsner]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160726073904

Steps to reproduce:

Create an event and add yourself (best with a differen mail adress) as participant. Add "+/-" to the description and save the event.
A mail with a ics is generated and sent to your other mail adress.
Open that mail with thunderbird with installed lightning.


Actual results:

The event invitation is not displayed.


Expected results:

The event invitation should be displayed.

The Problem is that .kGlyphSubstitution is used with scanHTML (file ltnInvitationUtils.jsm line 98) which produces non-standard HTML (see ). Removing this line solves the problem.

Comment 1

[kkapsner]

Forgot to insert the MDN link: https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/mozITXTToHTMLConv#scanHTML()

Comment 2

[[:MakeMyDay]]

Attachment: FixNonAsciiCharacterProblemInInvitationPreview-V1.diff

This patch takes care. I'm not removing kGlyphSubstitution mode because in most cases it works properly to convert smilies. Long term, we may make use of the chat implementation for that, but for now this is sufficient that way.

This needs to go up to esr, although we unfortunately missed the train for 4.7.4.

Comment 3

[Philipp Kewisch [:Fallen] [:📆]]

Comment on attachment 8795730 [details] [diff] [review]
FixNonAsciiCharacterProblemInInvitationPreview-V1.diff

Review of attachment 8795730 [details] [diff] [review]:
-----------------------------------------------------------------

The IDL says that kGlyphSubstitution should not be used with scanHTML at all. Maybe we should just remove it? Or does something speak for keeping it? 

Also, I'd appreciate if you could add a test that attempts to add a <script> tag or <img onerror="evil()"/>.

r/a=philipp with these changes

Comment 4

[Philipp Kewisch [:Fallen] [:📆]]

Ah I read your comment now. Fine for me to keep kGlyphSubstitution then.

Comment 5

[[:MakeMyDay]]

https://hg.mozilla.org/comm-central/rev/150b63fa66ecd865927c8c34e22e3e88f2608e04

Comment 6

[[:MakeMyDay]]

https://hg.mozilla.org/releases/comm-aurora/rev/414a326f7a5f7b0342c10ea4123ef2bff88b0443
https://hg.mozilla.org/releases/comm-beta/rev/47c2e4ec12d375d48740922b00368c8c48eb4124
https://hg.mozilla.org/releases/comm-esr45/rev/65fc9cd50f361c5ec996079fa7f5e7cc28340650