Unmark gray assertion failure in nsJSUtils::ModuleEvaluation

RESOLVED FIXED in Firefox 50

Status

()

Core
DOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

Trunk
mozilla51
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed, firefox51 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The patch in bug 1110928 triggers a black-gray invariant assertion failure, only on Android 4.3 API15+ debug. I assume this is some quirk that it always fails there.

The stack looks like this:
js::CompartmentChecker::check [jscntxtinlines.h:5001e8f1da97 : 71 + 0x2]
JS::ModuleEvaluation [jscntxtinlines.h:5001e8f1da97 : 83 + 0x3]
nsJSUtils::ModuleEvaluation [nsJSUtils.cpp:5001e8f1da97 : 329 + 0x7]
nsScriptLoader::EvaluateScript [nsScriptLoader.cpp:5001e8f1da97 : 2151 + 0x5]
nsScriptLoader::ProcessRequest [nsScriptLoader.cpp:5001e8f1da97 : 1953 + 0x7]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5001e8f1da97&selectedJob=27105527
(Assignee)

Comment 1

2 years ago
I think the getters on nsModuleScript should simply do the expose.
Assignee: nobody → continuation
> I think the getters on nsModuleScript should simply do the expose.

Yes, that is correct.  They should.
(Assignee)

Comment 3

2 years ago
That fixed my issue:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=306f6996c495

I suppose I should do a real try run, too.
Comment hidden (mozreview-request)

Comment 6

2 years ago
mozreview-review
Comment on attachment 8789881 [details]
Bug 1301189 - Use ExposeObjectToActiveJS in nsModuleScript.

https://reviewboard.mozilla.org/r/77934/#review76366
Attachment #8789881 - Flags: review?(bugs) → review+

Comment 7

2 years ago
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dbeaca20e104
Use ExposeObjectToActiveJS in nsModuleScript. r=smaug

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/dbeaca20e104
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
(Assignee)

Updated

2 years ago
Blocks: 1296848
(Assignee)

Comment 9

2 years ago
Comment on attachment 8789881 [details]
Bug 1301189 - Use ExposeObjectToActiveJS in nsModuleScript.

Approval Request Comment
[Feature/regressing bug #]: bug 1240072
[User impact if declined]: possible crashes
[Describe test coverage new/current, TreeHerder]: I think this code has tests
[Risks and why]: low
[String/UUID change made/needed]: none
Attachment #8789881 - Flags: approval-mozilla-aurora?

Updated

2 years ago
status-firefox50: --- → affected
Comment on attachment 8789881 [details]
Bug 1301189 - Use ExposeObjectToActiveJS in nsModuleScript.

Crash fix, has been on Nightly for a week, Aurora50+
Attachment #8789881 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 11

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/ade8492b5680
status-firefox50: affected → fixed
You need to log in before you can comment on or make changes to this bug.