Closed
Bug 1301198
Opened 8 years ago
Closed 8 years ago
Don't return [value, errors] tuples from MessageContext
Categories
(L20n :: JS Library, defect)
L20n
JS Library
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stas, Assigned: stas)
Details
(Whiteboard: [gecko-l20n])
Attachments
(1 file)
Always returning a [value, errors] tuples can be costly, especially in the success scenario where the errors array is empty. By optimizing this out we could shave off 2-3 ms off of browser.xul startup. Axel's suggestions was to pass in an additional argument which is a reference to an array of errors.
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → stas
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=117902ebf75b
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8789080 [details] Bug 1301198 - Don't return [value, errors] tuples from MessageContext. https://reviewboard.mozilla.org/r/77330/#review75666
Attachment #8789080 -
Flags: review?(gandalf) → review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
https://hg.mozilla.org/projects/larch/rev/e08d409563b9ffd12712be02a0ac2fa9dae879f8 Bug 1301198 - Don't return [value, errors] tuples from MessageContext. r=gandalf
|
|
Assignee | |
Comment 5•8 years ago
|
||
https://github.com/l20n/l20n.js/commit/2513f002e9d95e59e0e8df8f8cc05f9dd6d8a2d1
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•