Avoid inheriting the origin attributes of the subject principal if it's system

RESOLVED FIXED in Firefox 51

Status

()

Core
DOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Ehsan, Unassigned)

Tracking

unspecified
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Reporter)

Updated

2 years ago
See Also: → bug 1300817
(Reporter)

Comment 1

2 years ago
Created attachment 8789065 [details] [diff] [review]
Avoid inheriting the origin attributes of the subject principal if it's system
Attachment #8789065 - Flags: review?(bzbarsky)
Comment on attachment 8789065 [details] [diff] [review]
Avoid inheriting the origin attributes of the subject principal if it's system

r=me.  Though in the expanded/system principal case maybe it would make sense to inherit aParent's origin attributes?
Attachment #8789065 - Flags: review?(bzbarsky) → review+
(Reporter)

Comment 3

2 years ago
(In reply to Boris Zbarsky [:bz] from comment #2)
> Comment on attachment 8789065 [details] [diff] [review]
> Avoid inheriting the origin attributes of the subject principal if it's
> system
> 
> r=me.  Though in the expanded/system principal case maybe it would make
> sense to inherit aParent's origin attributes?

Hmm, maybe, but I'm curious to know your reasoning.  Can you please elaborate?

(FWIW I think we should make that change in a separate bug, if needed.)

Comment 4

2 years ago
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0322637f5ea
Avoid inheriting the origin attributes of the subject principal if it's system; r=bzbarsky
> Hmm, maybe, but I'm curious to know your reasoning.  Can you please elaborate?

Sure.  Consider the "chrome or expanded principal calls window.open on a content window" case.  I think after the changes in this bug, that window will not be opened with any interesting OA, but it might make sense to use the OA of the content window the open() call happened on.

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c0322637f5ea
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.