1301226 - Add mochitest for .wav with bad data chunk length

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Follow-up to bug 1287397 comment 30, we should write a mochitest with the test files in attachment 8771932 [details] and attachment 8773178 [details].

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1301226 - Test 0xFFFFFFFF WAV data chunk length -

Test that a WAV file with 0xFFFFFFFF data chunk length does not overflow, by
playing it; If it did overflow, its duration would be 0, and therefore would
not play.

Review commit: https://reviewboard.mozilla.org/r/90956/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/90956/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1301226 - Handle odd WAV chunk lengths -

'fmt ' and 'LIST' chunks could theoretically (but unlikely) have an off length,
in which case the following chunk will start at the next even offset.

Added test case.

Review commit: https://reviewboard.mozilla.org/r/90958/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/90958/

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8808036 [details]
Bug 1301226 - Handle odd WAV chunk lengths -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/90958/diff/1-2/

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8808035 [details]
Bug 1301226 - Test 0xFFFFFFFF WAV data chunk length -

https://reviewboard.mozilla.org/r/90956/#review90958

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8808036 [details]
Bug 1301226 - Handle odd WAV chunk lengths -

https://reviewboard.mozilla.org/r/90958/#review90964

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Thank you for your reviews today.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cea9d0937e3b
Test 0xFFFFFFFF WAV data chunk length - r=cpearce
https://hg.mozilla.org/integration/autoland/rev/c7a47678290a
Handle odd WAV chunk lengths - r=cpearce

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cea9d0937e3b
https://hg.mozilla.org/mozilla-central/rev/c7a47678290a