Re-enable jsat mochitests on Windows

RESOLVED FIXED in Firefox 52

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: aklotz, Assigned: aklotz)

Tracking

(Blocks 1 bug)

Trunk
mozilla52
Unspecified
Windows
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 affected, firefox52 fixed)

Details

Attachments

(1 attachment)

Assignee

Comment 1

3 years ago
These are fixed too (well, they don't crash in non-e10s mode anymore). I do see timeouts when forcing e10s, but those are not run by default at this time.
Assignee

Comment 2

3 years ago
Posted patch PatchSplinter Review
Assignee: nobody → aklotz
Status: NEW → ASSIGNED
Attachment #8795949 - Flags: review?(yzenevich)
Comment on attachment 8795949 [details] [diff] [review]
Patch

Review of attachment 8795949 [details] [diff] [review]:
-----------------------------------------------------------------

thanks
Attachment #8795949 - Flags: review?(yzenevich) → review+
Getting close: permaorange on WinXP like https://treeherder.mozilla.org/logviewer.html#?job_id=37408611&repo=mozilla-inbound but fine on Win7 and Win8, so once you switch to just skipping on WinXP you should finally make it stick.

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/65c02bf0a79284e7074214484c1f0559c6906491
Aaron, I think it is probably good to get these running afterall... I guess you could reland with:
skip-if = os != "win" || os_version == "5.1" || os_version == "5.2"

(If that is how we skip winxp...)
(In reply to David Bolter [:davidb] from comment #8)
> Aaron, I think it is probably good to get these running afterall... I guess
> you could reland with:
> skip-if = os != "win" || os_version == "5.1" || os_version == "5.2"

Doh, more like:
skip-if = os == "win" && ( os_version == "5.1" || os_version == "5.2") (not sure of syntax)
Assignee

Updated

3 years ago
Flags: needinfo?(aklotz)

Comment 11

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3f8db538d719
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.