1301232 - Re-enable jsat mochitests on Windows

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Klotz [:aklotz]]

Turned off by
https://hg.mozilla.org/mozilla-central/rev/baf4430c62c0
and
https://hg.mozilla.org/mozilla-central/rev/748308e48c83

These should run unconditionally.

Comment 1

[Aaron Klotz [:aklotz]]

These are fixed too (well, they don't crash in non-e10s mode anymore). I do see timeouts when forcing e10s, but those are not run by default at this time.

Comment 2

[Aaron Klotz [:aklotz]]

Attachment: Patch

Comment 3

[Yura Zenevich [:yzen]]

Comment on attachment 8795949 [details] [diff] [review]
Patch

Review of attachment 8795949 [details] [diff] [review]:
-----------------------------------------------------------------

thanks

Comment 4

[Aaron Klotz [:aklotz]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f64158062a657b86a2c29a7152afc929b6440993
Bug 1301232: Re-enable jsat mochitests on Windows; r=yzen

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This caused Windows debug mochitest-oth to permaleak like https://treeherder.mozilla.org/logviewer.html#?job_id=36744241&repo=mozilla-inbound

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/7da9a83dea36

Comment 6

[Aaron Klotz [:aklotz]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0257341f6b62d1387afa4aeceb49b53979a66b98
Bug 1301232: Re-enable jsat mochitests on Windows; r=yzen

Comment 7

[Phil Ringnalda (:philor)]

Getting close: permaorange on WinXP like https://treeherder.mozilla.org/logviewer.html#?job_id=37408611&repo=mozilla-inbound but fine on Win7 and Win8, so once you switch to just skipping on WinXP you should finally make it stick.

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/65c02bf0a79284e7074214484c1f0559c6906491

Comment 8

[David Bolter [:davidb] (NeedInfo me for attention)]

Aaron, I think it is probably good to get these running afterall... I guess you could reland with:
skip-if = os != "win" || os_version == "5.1" || os_version == "5.2"

(If that is how we skip winxp...)

Comment 9

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to David Bolter [:davidb] from comment #8)
> Aaron, I think it is probably good to get these running afterall... I guess
> you could reland with:
> skip-if = os != "win" || os_version == "5.1" || os_version == "5.2"

Doh, more like:
skip-if = os == "win" && ( os_version == "5.1" || os_version == "5.2") (not sure of syntax)

Comment 10

[Aaron Klotz [:aklotz]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3f8db538d719155fa15f4d3b8a1daec52bf1ebf5
Bug 1301232: Re-enable jsat mochitests on Windows; r=yzen

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3f8db538d719