Closed
Bug 1301232
Opened 6 years ago
Closed 6 years ago
Re-enable jsat mochitests on Windows
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla52
People
(Reporter: bugzilla, Assigned: bugzilla)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
934 bytes,
patch
|
yzen
:
review+
|
Details | Diff | Splinter Review |
Turned off by https://hg.mozilla.org/mozilla-central/rev/baf4430c62c0 and https://hg.mozilla.org/mozilla-central/rev/748308e48c83 These should run unconditionally.
Assignee | ||
Comment 1•6 years ago
|
||
These are fixed too (well, they don't crash in non-e10s mode anymore). I do see timeouts when forcing e10s, but those are not run by default at this time.
Assignee | ||
Comment 2•6 years ago
|
||
Comment 3•6 years ago
|
||
Comment on attachment 8795949 [details] [diff] [review] Patch Review of attachment 8795949 [details] [diff] [review]: ----------------------------------------------------------------- thanks
Attachment #8795949 -
Flags: review?(yzenevich) → review+
Assignee | ||
Comment 4•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f64158062a657b86a2c29a7152afc929b6440993 Bug 1301232: Re-enable jsat mochitests on Windows; r=yzen
This caused Windows debug mochitest-oth to permaleak like https://treeherder.mozilla.org/logviewer.html#?job_id=36744241&repo=mozilla-inbound Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/7da9a83dea36
Flags: needinfo?(aklotz)
Assignee | ||
Comment 6•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0257341f6b62d1387afa4aeceb49b53979a66b98 Bug 1301232: Re-enable jsat mochitests on Windows; r=yzen
Comment 7•6 years ago
|
||
Getting close: permaorange on WinXP like https://treeherder.mozilla.org/logviewer.html#?job_id=37408611&repo=mozilla-inbound but fine on Win7 and Win8, so once you switch to just skipping on WinXP you should finally make it stick. Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/65c02bf0a79284e7074214484c1f0559c6906491
Comment 8•6 years ago
|
||
Aaron, I think it is probably good to get these running afterall... I guess you could reland with: skip-if = os != "win" || os_version == "5.1" || os_version == "5.2" (If that is how we skip winxp...)
Comment 9•6 years ago
|
||
(In reply to David Bolter [:davidb] from comment #8) > Aaron, I think it is probably good to get these running afterall... I guess > you could reland with: > skip-if = os != "win" || os_version == "5.1" || os_version == "5.2" Doh, more like: skip-if = os == "win" && ( os_version == "5.1" || os_version == "5.2") (not sure of syntax)
Assignee | ||
Comment 10•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f8db538d719155fa15f4d3b8a1daec52bf1ebf5 Bug 1301232: Re-enable jsat mochitests on Windows; r=yzen
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(aklotz)
Comment 11•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3f8db538d719
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•