1301254 - nsINode::GetBaseURI() should be fallible

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Nicholas Nethercote [inactive]]

This is a spin-off of bug 1297300, which is adding checking for GetSpec() calls that are lacking them.

nsINode::GetBaseURI() has a GetSpec() call that is fallible. The right way to handle this is to make nsIDocument::GetDocumentURI() itself fallible. bz noted in bug 1297300 comment 31.

It should also be marked with MOZ_MUST_USE, of course :)

Comment 1

[Andrew Overholt [:overholt]]

Please let me know if this should be a higher priority than "backlog".

Comment 2

[Nicholas Nethercote [inactive]]

> Please let me know if this should be a higher priority than "backlog".

That seems fine. Thank you for checking.

Comment 3

[Andrea Marchesini [:baku]]

Attachment: doc2.patch

Comment 4

[Nicholas Nethercote [inactive]]

Comment on attachment 8791139 [details] [diff] [review]
doc2.patch

Review of attachment 8791139 [details] [diff] [review]:
-----------------------------------------------------------------

Looks ok, but I'll defer to a DOM peer for r+.

::: dom/xslt/xpath/txXPathTreeWalker.h
@@ +92,5 @@
>      static int32_t getUniqueIdentifier(const txXPathNode& aNode);
>      static nsresult getXSLTId(const txXPathNode& aNode,
>                                const txXPathNode& aBase, nsAString& aResult);
>      static void release(txXPathNode* aNode);
> +    static nsresult getBaseURI(const txXPathNode& aNode, nsAString& aURI);

Please add MOZ_MUST_USE here.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8791139 [details] [diff] [review]
doc2.patch

Also in this bug, I don't understand why to use ErrorResult, when nsresult is the normal way to propagate errors in Gecko, and ErrorResult is more like webidl layer thing.

Comment 6

[Andrea Marchesini [:baku]]

Attachment: doc2.patch

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/31ea105ca2d9
nsINode::GetBaseURI() should be fallible, r=smaug

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/31ea105ca2d9

Comment 9

[Gerry Chang [:gchang]]

Mark 51 as fix-optional. If it's worth uplift to 51, feel free to nominate it.