Closed Bug 1301333 Opened 5 years ago Closed 3 years ago

[Static Analysis][Clang-Plugin] Mark functions that initialize member variables for their parent class

Categories

(Firefox Build System :: Source Code Analysis, defect)

defect
Not set
normal

Tracking

(firefox51 affected)

RESOLVED FIXED
Tracking Status
firefox51 --- affected

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: sec-audit)

Attachments

(6 files, 3 obsolete files)

58 bytes, text/x-review-board-request
mccr8
: review+
Details
704 bytes, patch
bholley
: review+
andi
: review+
Details | Diff | Splinter Review
756 bytes, patch
jrmuizel
: review+
Details | Diff | Splinter Review
769 bytes, patch
cpearce
: review+
Details | Diff | Splinter Review
850 bytes, patch
baku
: review+
Details | Diff | Splinter Review
863 bytes, patch
jorendorff
: review+
Details | Diff | Splinter Review
As many of the member variables are not initialised in their constructor and in functions like Init(), we want to mark this type of function that our static analysis tool can check.

On this bug there will be posted patches of this kind.
MozReview-Commit-ID: Ef8oHnmrZM8
Attachment #8789298 - Flags: review?(amarchesini)
Attachment #8789298 - Flags: review?(amarchesini) → review+
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7697db0f0887
mark Init as initialisation function for EventSource. r=baku
Comment on attachment 8789298 [details] [diff] [review]
mark Init as initialisation function for EventSource

https://hg.mozilla.org/integration/mozilla-inbound/rev/7697db0f0887
Attachment #8789298 - Attachment is obsolete: true
MozReview-Commit-ID: HYj244xg1VD
Attachment #8791947 - Flags: review?(bobbyholley)
MozReview-Commit-ID: 4mveFlHumVE
Attachment #8791959 - Flags: review?(jmuizelaar)
Comment on attachment 8791959 [details] [diff] [review]
mark ImageBridgeThread::Init as initialisation function for ImageBridgeThread

Review of attachment 8791959 [details] [diff] [review]:
-----------------------------------------------------------------

Can we just omit the #ifdef and mark the function unconditionally?
Attachment #8791959 - Flags: review?(jmuizelaar) → review+
MozReview-Commit-ID: 4mveFlHumVE
Attachment #8791976 - Flags: review?(jmuizelaar)
Attachment #8791959 - Attachment is obsolete: true
Attachment #8791976 - Attachment is obsolete: true
Attachment #8791976 - Flags: review?(jmuizelaar)
Attachment #8791959 - Attachment is obsolete: false
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/caa8a9c7d122
mark ImageBridgeThread::Init as initialisation function for ImageBridgeThread. r=jrmuizel
Attachment #8791959 - Flags: checkin+
Attachment #8789298 - Attachment is obsolete: false
Attachment #8789298 - Flags: checkin+
Comment on attachment 8791933 [details]
Bug 1301333 - mark Initialize as initialisation function for CycleCollectedJSContext.

https://reviewboard.mozilla.org/r/79208/#review77824
Attachment #8791933 - Flags: review?(continuation) → review+
Attachment #8791947 - Flags: review?(bobbyholley) → review+
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f9db96226c0c
mark Initialize as initialisation function for CycleCollectedJSContext. r=mccr8
Attachment #8791933 - Flags: checkin+
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6cf09a35f529
mark XPCJSContext::Initialize as initialisation function for XPCJSContext. r=bobbyholley
Attachment #8791947 - Flags: review+
MozReview-Commit-ID: 7xkkoS5Q7t
Attachment #8795265 - Flags: review?(cpearce)
Attachment #8795265 - Flags: review?(cpearce) → review+
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6f0cf0441dd
mark InitIPDL as initialisation function for VideoDecoderChild. r=cpearce
Comment on attachment 8795265 [details] [diff] [review]
mark InitIPDL as initialisation function for VideoDecoderChild

https://hg.mozilla.org/integration/mozilla-inbound/rev/b6f0cf0441dd
Attachment #8795265 - Flags: checkin+
MozReview-Commit-ID: JNCBpgHjhs1
Attachment #8801104 - Flags: review?(amarchesini)
Attachment #8789298 - Attachment is obsolete: true
Attachment #8801104 - Flags: review?(amarchesini) → review+
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/50d3ed5433af
Add mark-initialisation-func annotation to function Init from PresentationReceiver. r=baku
Attachment #8801104 - Flags: checkin+
MozReview-Commit-ID: KKUX4FE0pth
Attachment #8802053 - Flags: review?(amarchesini)
Attachment #8802053 - Flags: review?(amarchesini) → review+
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5bc34a1ebba2
Add mark-initialisation-func annotation to functions Init and DoInitOnMainThread from GetUsageOp. r=baku
Attachment #8802053 - Flags: checkin+
MozReview-Commit-ID: 4qsINKxyACT
Attachment #8818206 - Flags: review?(jorendorff)
Attachment #8801104 - Attachment is obsolete: true
Comment on attachment 8818206 [details] [diff] [review]
mark init as initialisation function for ModuleCharsForStore

Fell off my radar, but this still applies and can land.
Attachment #8818206 - Flags: review?(jorendorff) → review+
Product: Core → Firefox Build System
The leave-open keyword is there and there is no activity for 6 months.
:andi, maybe it's time to close this bug?
Flags: needinfo?(bpostelnicu)
We should close this, since these have already been integrated.
Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(bpostelnicu)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.