If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[Static Analysis][Clang-Plugin] Mark functions that initialize member variables for their parent class

NEW
Assigned to

Status

()

Core
Rewriting and Analysis
a year ago
10 months ago

People

(Reporter: andi, Assigned: andi)

Tracking

(Blocks: 3 bugs, {leave-open, sec-audit})

Trunk
leave-open, sec-audit
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 affected)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(6 attachments, 3 obsolete attachments)

58 bytes, text/x-review-board-request
mccr8
: review+
andi
: checkin+
Details | Review
704 bytes, patch
bholley
: review+
andi
: review+
Details | Diff | Splinter Review
756 bytes, patch
jrmuizel
: review+
andi
: checkin+
Details | Diff | Splinter Review
769 bytes, patch
cpearce
: review+
andi
: checkin+
Details | Diff | Splinter Review
850 bytes, patch
baku
: review+
andi
: checkin+
Details | Diff | Splinter Review
863 bytes, patch
andi
: review?
jorendorff
Details | Diff | Splinter Review
(Assignee)

Description

a year ago
As many of the member variables are not initialised in their constructor and in functions like Init(), we want to mark this type of function that our static analysis tool can check.

On this bug there will be posted patches of this kind.
(Assignee)

Comment 1

a year ago
Created attachment 8789298 [details] [diff] [review]
mark Init as initialisation function for EventSource

MozReview-Commit-ID: Ef8oHnmrZM8
Attachment #8789298 - Flags: review?(amarchesini)
Attachment #8789298 - Flags: review?(amarchesini) → review+

Comment 2

a year ago
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7697db0f0887
mark Init as initialisation function for EventSource. r=baku
(Assignee)

Comment 3

a year ago
Comment on attachment 8789298 [details] [diff] [review]
mark Init as initialisation function for EventSource

https://hg.mozilla.org/integration/mozilla-inbound/rev/7697db0f0887
Attachment #8789298 - Attachment is obsolete: true

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7697db0f0887
Comment hidden (mozreview-request)
(Assignee)

Comment 6

a year ago
Created attachment 8791947 [details] [diff] [review]
mark XPCJSContext::Initialize as initialisation function for XPCJSContext

MozReview-Commit-ID: HYj244xg1VD
Attachment #8791947 - Flags: review?(bobbyholley)
(Assignee)

Comment 7

a year ago
Created attachment 8791959 [details] [diff] [review]
mark ImageBridgeThread::Init as initialisation function for ImageBridgeThread

MozReview-Commit-ID: 4mveFlHumVE
Attachment #8791959 - Flags: review?(jmuizelaar)
Comment on attachment 8791959 [details] [diff] [review]
mark ImageBridgeThread::Init as initialisation function for ImageBridgeThread

Review of attachment 8791959 [details] [diff] [review]:
-----------------------------------------------------------------

Can we just omit the #ifdef and mark the function unconditionally?
Attachment #8791959 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 9

a year ago
Created attachment 8791976 [details] [diff] [review]
mark ImageBridgeThread::Init as initialisation function for ImageBridgeThread

MozReview-Commit-ID: 4mveFlHumVE
Attachment #8791976 - Flags: review?(jmuizelaar)
(Assignee)

Updated

a year ago
Attachment #8791959 - Attachment is obsolete: true
(Assignee)

Updated

a year ago
Attachment #8791976 - Attachment is obsolete: true
Attachment #8791976 - Flags: review?(jmuizelaar)
(Assignee)

Updated

a year ago
Attachment #8791959 - Attachment is obsolete: false

Comment 10

a year ago
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/caa8a9c7d122
mark ImageBridgeThread::Init as initialisation function for ImageBridgeThread. r=jrmuizel
(Assignee)

Updated

a year ago
Attachment #8791959 - Flags: checkin+
(Assignee)

Updated

a year ago
Attachment #8789298 - Attachment is obsolete: false
Attachment #8789298 - Flags: checkin+

Comment 11

a year ago
mozreview-review
Comment on attachment 8791933 [details]
Bug 1301333 - mark Initialize as initialisation function for CycleCollectedJSContext.

https://reviewboard.mozilla.org/r/79208/#review77824
Attachment #8791933 - Flags: review?(continuation) → review+

Comment 12

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/caa8a9c7d122
Attachment #8791947 - Flags: review?(bobbyholley) → review+

Comment 13

a year ago
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f9db96226c0c
mark Initialize as initialisation function for CycleCollectedJSContext. r=mccr8
(Assignee)

Updated

a year ago
Attachment #8791933 - Flags: checkin+

Comment 14

a year ago
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6cf09a35f529
mark XPCJSContext::Initialize as initialisation function for XPCJSContext. r=bobbyholley
(Assignee)

Updated

a year ago
Attachment #8791947 - Flags: review+

Comment 15

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f9db96226c0c

Comment 16

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6cf09a35f529
(Assignee)

Comment 17

a year ago
Created attachment 8795265 [details] [diff] [review]
mark InitIPDL as initialisation function for VideoDecoderChild

MozReview-Commit-ID: 7xkkoS5Q7t
Attachment #8795265 - Flags: review?(cpearce)
Attachment #8795265 - Flags: review?(cpearce) → review+

Comment 18

a year ago
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6f0cf0441dd
mark InitIPDL as initialisation function for VideoDecoderChild. r=cpearce
(Assignee)

Comment 19

a year ago
Comment on attachment 8795265 [details] [diff] [review]
mark InitIPDL as initialisation function for VideoDecoderChild

https://hg.mozilla.org/integration/mozilla-inbound/rev/b6f0cf0441dd
Attachment #8795265 - Flags: checkin+

Comment 20

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b6f0cf0441dd
(Assignee)

Comment 21

a year ago
Created attachment 8801104 [details] [diff] [review]
Add mark-initialisation-func annotation to function Init from PresentationReceiver

MozReview-Commit-ID: JNCBpgHjhs1
Attachment #8801104 - Flags: review?(amarchesini)
(Assignee)

Updated

a year ago
Attachment #8789298 - Attachment is obsolete: true
Attachment #8801104 - Flags: review?(amarchesini) → review+

Comment 22

a year ago
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/50d3ed5433af
Add mark-initialisation-func annotation to function Init from PresentationReceiver. r=baku
(Assignee)

Updated

a year ago
Attachment #8801104 - Flags: checkin+

Comment 23

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/50d3ed5433af
(Assignee)

Comment 24

11 months ago
Created attachment 8802053 [details] [diff] [review]
Add mark-initialisation-func annotation to functions Init and DoInitOnMainThread from GetUsageOp

MozReview-Commit-ID: KKUX4FE0pth
Attachment #8802053 - Flags: review?(amarchesini)

Updated

11 months ago
Attachment #8802053 - Flags: review?(amarchesini) → review+

Comment 25

11 months ago
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5bc34a1ebba2
Add mark-initialisation-func annotation to functions Init and DoInitOnMainThread from GetUsageOp. r=baku
(Assignee)

Updated

11 months ago
Attachment #8802053 - Flags: checkin+

Comment 26

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5bc34a1ebba2
(Assignee)

Comment 27

10 months ago
Created attachment 8818206 [details] [diff] [review]
mark init as initialisation function for ModuleCharsForStore

MozReview-Commit-ID: 4qsINKxyACT
Attachment #8818206 - Flags: review?(jorendorff)
(Assignee)

Updated

10 months ago
Attachment #8801104 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.