1301339 - Annotate content shutdown hang due to nested event loop in RecvShutdown

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Kan-Ru Chen [:kanru] (UTC+9)]

We currently allow nested event loop to delay ContentChild::RecvShutdown which in turn might cause content process shutdown hang. This patch attempts to annotate the crash report that a shutdown hang was after we have received RecvShutdown but never reach SendFinishShutdown or the hang happened before or after RecvShutdown.

Comment 1

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: Bug 1301339 - Annotate content shutdown hang due to nested event loop in RecvShutdown.

We currently allow nested event loop to delay ContentChild::RecvShutdown
which in turn might cause content process shutdown hang. This patch
attempts to annotate the crash report that a shutdown hang was after we
have received RecvShutdown but never reach SendFinishShutdown or the
hang happened before or after RecvShutdown.

Review commit: https://reviewboard.mozilla.org/r/77582/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77582/

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8789304 [details]
Bug 1301339 - Annotate content shutdown hang due to nested event loop in RecvShutdown.

https://reviewboard.mozilla.org/r/77582/#review76122

Maybe it would be better to have one annotation, IPCShutdownState, that could be either empty, "RecvShutdown", or "SendFinishShutdown"?

Comment 3

[Kan-Ru Chen [:kanru] (UTC+9)]

(In reply to Bill McCloskey (:billm) from comment #2)
> Comment on attachment 8789304 [details]
> Bug 1301339 - Annotate content shutdown hang due to nested event loop in
> RecvShutdown.
> 
> https://reviewboard.mozilla.org/r/77582/#review76122
> 
> Maybe it would be better to have one annotation, IPCShutdownState, that
> could be either empty, "RecvShutdown", or "SendFinishShutdown"?

Sounds good.

Comment 4

[Kan-Ru Chen [:kanru] (UTC+9)]

Comment on attachment 8789304 [details]
Bug 1301339 - Annotate content shutdown hang due to nested event loop in RecvShutdown.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77582/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/399174fe175a
Annotate content shutdown hang due to nested event loop in RecvShutdown. r=billm

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/399174fe175a