Annotate content shutdown hang due to nested event loop in RecvShutdown

RESOLVED FIXED in Firefox 51

Status

()

Core
DOM: Content Processes
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: kanru, Assigned: kanru)

Tracking

(Blocks: 1 bug)

unspecified
mozilla51
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
We currently allow nested event loop to delay ContentChild::RecvShutdown which in turn might cause content process shutdown hang. This patch attempts to annotate the crash report that a shutdown hang was after we have received RecvShutdown but never reach SendFinishShutdown or the hang happened before or after RecvShutdown.
(Assignee)

Updated

2 years ago
Assignee: nobody → kchen
Blocks: 1279293
Comment hidden (mozreview-request)
Comment on attachment 8789304 [details]
Bug 1301339 - Annotate content shutdown hang due to nested event loop in RecvShutdown.

https://reviewboard.mozilla.org/r/77582/#review76122

Maybe it would be better to have one annotation, IPCShutdownState, that could be either empty, "RecvShutdown", or "SendFinishShutdown"?
Attachment #8789304 - Flags: review?(wmccloskey) → review+
(Assignee)

Comment 3

2 years ago
(In reply to Bill McCloskey (:billm) from comment #2)
> Comment on attachment 8789304 [details]
> Bug 1301339 - Annotate content shutdown hang due to nested event loop in
> RecvShutdown.
> 
> https://reviewboard.mozilla.org/r/77582/#review76122
> 
> Maybe it would be better to have one annotation, IPCShutdownState, that
> could be either empty, "RecvShutdown", or "SendFinishShutdown"?

Sounds good.
Comment hidden (mozreview-request)

Comment 5

2 years ago
Pushed by kchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/399174fe175a
Annotate content shutdown hang due to nested event loop in RecvShutdown. r=billm

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/399174fe175a
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.