1301380 - Make ROUTING_KEYS configurable

Status: VERIFIED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Johan Lorenzo [:jlorenzo]]

release-automation-notifications@m.c got emails from the staging release pipeline[1]. Rail pointed out that pulse-notify listens to a given set of TaskClusters routes, no matter if we're in prod or staging[2].

Let's make [2] configurable via an env var.

[1] For instance: https://groups.google.com/a/mozilla.com/forum/?utm_medium=email&utm_source=footer#!msg/release-automation-notifications/JHysVVa-IK4/riY3HgjIAQAJ
[2] https://github.com/mozilla-releng/pulse-notify/blob/8b2a51e77b29965ab1cb2deac8557c79ca8b72f2/pulsenotify/consumer.py#L27

Comment 1

[Connor Sheehan [:sheehan]]

Attachment: Moves source of ROUTING_KEYS to 'ROUTING_KEYS' env var

Comment 2

[Rail Aliiev [:rail]]

Comment on attachment 8789537 [details] [review]
Moves source of ROUTING_KEYS to 'ROUTING_KEYS' env var

LGTM. Before merging these, we should add the corresponding routes to the heroku apps.

Comment 3

[Johan Lorenzo [:jlorenzo]]

These routes have been added:
* to production instance => route.index.releases.v1.mozilla-beta.#:route.index.releases.v1.mozilla-esr45.#:route.index.releases.v1.mozilla-release.#
* to dev instance => route.index.releases.v1.jamun.#

In order to test the dev instance, I plugged heroku to mozilla-releng/pulse-notify#master. Please, let me know if I should wire it back to cgsheeh/pulse-notify#master.

I think we're ready to merge in master and in production.

Comment 4

[Rail Aliiev [:rail]]

(In reply to Johan Lorenzo [:jlorenzo] from comment #3)
> I think we're ready to merge in master and in production.

Sweet. Let's do it! On it.

Comment 5

[Rail Aliiev [:rail]]

This is should be done now.

* adjusted the dev pulse credentials and queue name to be under the same account
* killed the queues using pulseguardian (otherwise they won't unbind the old routing keys)
* restarted the prod dyno and started the dev dyno to make sure the queues are recreated with the new routing keys.
* verified the list of keys in pulseguardian - all look good!

Thank you Connor!

Comment 6

[Johan Lorenzo [:jlorenzo]]

I just started a release in ship-it-dev. I confirm the notifications are now sent to release-automation-notifications-dev only[1]. Thank you Connor :) 

[1] https://groups.google.com/a/mozilla.com/forum/?utm_medium=email&utm_source=footer#!msg/release-automation-notifications-dev/OFHdKcYBuYY/bj8CN9fXAQAJ